git hook: don't commit whole file #470
Conversation
|
Could you add some test verifying this behaviour and update changelog? |
|
@Tapchicoma Can you re-review this please. Also, how do you build this project at all? I can only get pages of gradle errors and the steps in the readme didn't help. |
If you want to run some test - best option is to open Also sample project automatically apply all current changes from plugin subproject. |
| @@ -138,6 +138,30 @@ class GitHookTasksTest : AbstractPluginTest() { | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| internal fun `Format hook should not add non-indexed code to the commit`() { | |||
| // TODO: This test doesn't run git or verify that only indexed code is committed, | |||
There was a problem hiding this comment.
Too bad JGit does have partial staging 😒
There was a problem hiding this comment.
What do you mean?
|
This updated precommit hook causes conflicts when you try to commit a badly-formatted change. See #497. |
When you commit part of a file the current git hook will change your commit to being the entire file.
This pr stashes the worktree before fmt, and unstashed before finished