Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix gradle deprecation warning #480

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Fix gradle deprecation warning #480

merged 1 commit into from
Jun 2, 2021

Conversation

KotlinIsland
Copy link
Contributor

@KotlinIsland KotlinIsland commented May 11, 2021 •
edited by Tapchicoma
Loading

adds workaround for #457

Tapchicoma
Tapchicoma reviewed May 19, 2021
View reviewed changes
Copy link
Collaborator

@Tapchicoma Tapchicoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is rather workaround then a good solution. Kotlin scripts and Kotlin sources format tasks (and generate reports) should not depend on each other and should be able to run in parallel.

@pvegh
Copy link

pvegh commented Jun 1, 2021

Can we merge this, save us from millions of warnings, and put lipstick on the pig later?

@Tapchicoma
Copy link
Collaborator

@pvegh yes, I will merge it and look into cause/better solution for 10.2.0 release

@Tapchicoma
Copy link
Collaborator

FYI: @KotlinIsland seems your changelog check workflow is not working as expected. I would expect this PR will pass it as there is required entry in the changelog.

@Tapchicoma Tapchicoma added the skip news This PR does not require new changelog entry label Jun 2, 2021
@Tapchicoma Tapchicoma force-pushed the task-dependencies branch from 6ac5f7d to 929cc9e Compare June 2, 2021 17:26
@Tapchicoma Tapchicoma force-pushed the task-dependencies branch from 929cc9e to ccc2ee1 Compare June 2, 2021 18:45
@Tapchicoma Tapchicoma merged commit 5640b35 into JLLeitschuh:master Jun 2, 2021
@KotlinIsland
Copy link
Contributor Author

@Tapchicoma Sorry 😳here's a fix #493

@KotlinIsland KotlinIsland deleted the task-dependencies branch June 2, 2021 22:03
@AndreyKhranovsky-TomTom AndreyKhranovsky-TomTom mentioned this pull request Jun 3, 2021
Closed
@JLLeitschuh JLLeitschuh mentioned this pull request Nov 19, 2024
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Tapchicoma Tapchicoma Tapchicoma left review comments

@davidburstromspotify davidburstromspotify davidburstromspotify left review comments

Assignees
No one assigned
Labels
skip news This PR does not require new changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KotlinIsland @pvegh @Tapchicoma @davidburstromspotify