update configure-pagefile-action task #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wakingrufus
force-pushed
the
update-pagefile-task
branch
from
2c8ddcf to
c1ddfde
Compare
wakingrufus
force-pushed
the
update-pagefile-task
branch
3 times, most recently
from
be33348 to
88949e6
Compare
wakingrufus
commented
Nov 29, 2023
| @@ -99,8 +99,10 @@ jobs: | |||
| - name: set up JDK 1.8 | |||
| uses: actions/setup-java@v2 | |||
| with: | |||
| java-version: 8 | |||
| java-version: 11 | |||
There was a problem hiding this comment.
might as well run this on java 11
There was a problem hiding this comment.
Sure... But then change the title of the step too 🙂😂
wakingrufus
commented
Nov 29, 2023
| distribution: 'zulu' | ||
| - name: Install lintian | ||
| run: sudo apt install -qq lintian=2.114.0ubuntu1.3 |
There was a problem hiding this comment.
checkbashisms was resolving its transitive dependency on lintian to a version that no longer exists. i fixed it by explicitly installing a version of the dependency that actually exists
wakingrufus
commented
Nov 29, 2023
| @@ -306,10 +306,12 @@ gradlePlugin { | |||
| register("ktlintPlugin") { | |||
| id = "org.jlleitschuh.gradle.ktlint" | |||
| implementationClass = "org.jlleitschuh.gradle.ktlint.KtlintPlugin" | |||
| displayName = "Ktlint Gradle Plugin" | |||
There was a problem hiding this comment.
to pass new validation rules (this caused previous release to fail)
wakingrufus
commented
Nov 29, 2023
| @@ -30,7 +30,7 @@ jobs: | |||
| - uses: actions/checkout@v2 | |||
| - name: configure windows pagefile | |||
| if: ${{ matrix.os == 'windows-latest' }} | |||
| uses: al-cheb/configure-pagefile-action@v1.2 | |||
| uses: al-cheb/configure-pagefile-action@v1.3 | |||
There was a problem hiding this comment.
to solve node version warning
|
One thing to fix, then happy to merge! 🙂 |
add display name to plugin metadata to fix broken publish task
wakingrufus
force-pushed
the
update-pagefile-task
branch
from
88949e6 to
0584453
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add display name to plugin metadata to fix broken publish task