Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Updated default KtLint version to 1.5.0 #818

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

CPColin
Copy link

@CPColin CPColin commented Dec 9, 2024

No description provided.

Copy link

@qmg-cherryl qmg-cherryl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CPColin
Copy link
Author

CPColin commented Dec 15, 2024

I see your approvals, but GitHub isn't showing me a Merge button.

@wakingrufus
Copy link
Collaborator

This PR doesnt actually change the default version. only the version that the ktlint-gradle itself uses
We consider changing the default version a breaking change, since behavior will change for most users, so I am working on some other breaking changes we want to get in for the next major bump first, then I will come back to this.

@wallind
Copy link

wallind commented Feb 17, 2025

.. am working on some other breaking changes we want to get in for the next major bump first, then I will come back to this.

@wakingrufus Any rough idea on timeframes when we might expect this to be updated in a published version for this plugin?

My team is implementing the workaround described here #809 (comment), and are just wondering when we might be able to look forward to removing that override.

*I'm sure you're busy, so no rush on the response or release, just looking for intel 😇

@wakingrufus
Copy link
Collaborator

.. am working on some other breaking changes we want to get in for the next major bump first, then I will come back to this.

@wakingrufus Any rough idea on timeframes when we might expect this to be updated in a published version for this plugin?

My team is implementing the workaround described here #809 (comment), and are just wondering when we might be able to look forward to removing that override.

*I'm sure you're busy, so no rush on the response or release, just looking for intel 😇

Yeah i just started working on this again. I have another housekeeping PR open now, and next step is to make the jump

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants