Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Prefer PROJECT_SOURCE_DIR over CMAKE_SOURCE_DIR #684

Closed
Aaron-SP opened this issue Jul 25, 2022 · 3 comments
Closed

Prefer PROJECT_SOURCE_DIR over CMAKE_SOURCE_DIR #684

Aaron-SP opened this issue Jul 25, 2022 · 3 comments
Labels
Feature request

Comments

@Aaron-SP
Copy link
Contributor

When bundling JSBSIM as an external project using CMAKE FetchContent, JSBSIM is not configured because it uses CMAKE_SOURCE_DIR instead of PROJECT_SOURCE_DIR.

CMAKE Issue Explained

I've made a fork with this change at repo.

Does it make sense to make this change to expand packaging capabilities of JSBSim with CMAKE?
@bcoconni
Copy link
Member

Thanks for reporting this issue.
Would you mind submitting a pull request from your repo ?

@Aaron-SP Aaron-SP mentioned this issue Jul 28, 2022
Merged
@Aaron-SP
Copy link
Contributor Author

I have opened a pull request here. This fixes my issue but I did not check building the extra modules such as Python etc. We might want to double check that any files that code generate CMAKE are also updated, not sure.

@bcoconni
Copy link
Member

Your pull request has been merged.
Thanks for your contribution 👍

bcoconni pushed a commit to bcoconni/jsbsim that referenced this issue Aug 20, 2022
@Aaron-SP @bcoconni
Replace CMAKE_SOURCE_DIR with PROJECT_SOURCE_DIR instead (JSBSim…
186557f 
…-Team#689).

This allows embedding JSBSim into a higher level repository where JSBSim is not at the highest CMAKE level. This supports use cases such as CMAKE FetchContent.

Resolves JSBSim-Team#684
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bcoconni @Aaron-SP