Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Upgrade libexpat to 2.6.2 #1080

Merged
merged 3 commits into from
May 2, 2024
Merged

Conversation

bcoconni
Copy link
Member

@bcoconni bcoconni commented May 1, 2024

Upgrade JSBSim local copy of libexpat from 2.4.8 to 2.6.2. This new version includes a number of bugs and security fixes (see libexpat changelog for details).

For the record, JSBSim local copy of libexpat is used by the Python wheels from PyPI in order to support systems where libexpat is not installed (i.e Windows).

However, if libexpat is installed on your computer (including the header/dev files), CMake can compile JSBSim, include its Python module, using the global libexpat library as long as the flag -DSYSTEM_EXPAT=ON is set:

> cmake -DSYSTEM_EXPAT=ON [add-other-flags-as-needed] .

By default SYSTEM_EXPAT is set to OFF even if libexpat is installed on your computer:

option(SYSTEM_EXPAT "Set to ON to build JSBSim using the system libExpat" OFF)

Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.95%. Comparing base (c67311c) to head (e9d79d8).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1080   +/-   ##
=======================================
  Coverage   24.95%   24.95%           
=======================================
  Files         168      168           
  Lines       18072    18072           
=======================================
  Hits         4510     4510           
  Misses      13562    13562           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agodemar agodemar merged commit 92ebcca into JSBSim-Team:master May 2, 2024
30 checks passed
@bcoconni bcoconni deleted the libexpat-2.6.2 branch May 2, 2024 14:34
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants