Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to simplify the build of the Python module using CMake. Until this PR, the compilation of the Python module was delegated by the CMake scripts to the
setup.py
script.As a consequence
setup.py
had to address some build configurations that came from the CMake scripts options (dynamic linking and some flags settings) but this usage is beyond the "normal" scope of asetup.py
script. This madesetup.py
more complex than it should have had to be.This PR decouples the CMake scripts and the
setup.py
script as far as the Python module compilation is concerned. The scriptsetup.py
will still be generated by CMake but CMake will no longer callsetup.py
. Instead CMake will now uses the CMake commandPython3_add_library
to build the Python module and the scriptsetup.py
will only be used by our CI/CD workflow to build the Python wheels.This change result in the deletion of 3 files (
python/findModuleFileName.py
,python/fpectl/fpectl_config.h.in
,python/fpectl/setup.py.in
) and the removal of approximately 160 lines of build scripts (including the removed files).