Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: add features: filter and fold #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pawlufelice
Copy link

@pawlufelice pawlufelice commented Apr 27, 2023

Added breaking changes, which are not necessarily desired:

  • Maybe from is always nullable
  • Maybe#map is the same as .chain(x => fromNullable(fn(x)))
  • Added fold/match to Maybe
  • Added filter to Maybe

This is NOT ready to merge, and if it's in the right direction, will continue working on it (just didn't want to waste time if it's a no-go)

@pawlufelice pawlufelice changed the title feat: add features feat: add features: filter and fold Apr 27, 2023
@JSMonk
Copy link
Owner

JSMonk commented Jul 16, 2023

The PR looks really great. But, could I ask you to split it on the several PRs feature-by-feature? Because, some of the features I would like to merge right now, and some of them I would like to discuss.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants