Fix zowe#3422

Signed-off-by: JWaters02 <watersjoshua2002@gmail.com>
JWaters02 · Feb 6, 2025 · 373b527 · 373b527
1 parent eeeaf84
commit 373b527
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/packages/zowe-explorer/__tests__/__unit__/commands/ZoweCommandProvider.unit.test.ts b/packages/zowe-explorer/__tests__/__unit__/commands/ZoweCommandProvider.unit.test.ts
@@ -120,6 +120,13 @@ describe("ZoweCommandProvider Unit Tests", () => {
                 expect(createTerminal).not.toHaveBeenCalled();
             });
 
+            it("should not create a terminal if the command is empty", async () => {
+                const createTerminal = jest.fn().mockReturnValue({ show: jest.fn() });
+                Object.defineProperty(vscode.window, "createTerminal", { value: createTerminal, configurable: true });
+                await ZoweCommandProvider.prototype.issueCommand.call(mockCmdProvider, testProfile, "");
+                expect(createTerminal).not.toHaveBeenCalled();
+            });
+
             it("should create an integrated terminal", async () => {
                 const createTerminal = jest.fn().mockReturnValue({ show: jest.fn() });
                 Object.defineProperty(vscode.window, "createTerminal", { value: createTerminal, configurable: true });

diff --git a/packages/zowe-explorer/src/commands/ZoweCommandProvider.ts b/packages/zowe-explorer/src/commands/ZoweCommandProvider.ts
@@ -61,6 +61,10 @@ export abstract class ZoweCommandProvider {
         if (profile == null || command == null) {
             return;
         }
+        if (command.length === 0) {
+            Gui.showMessage(this.operationCancelled);
+            return;
+        }
         try {
             const iTerms = SettingsConfig.getDirectValue(Constants.SETTINGS_COMMANDS_INTEGRATED_TERMINALS);
             if (iTerms) {