Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Calc quality analysis needs to be updated #325

Closed
naik-aakash opened this issue Aug 12, 2024 · 4 comments · Fixed by #331
Closed

Calc quality analysis needs to be updated #325

naik-aakash opened this issue Aug 12, 2024 · 4 comments · Fixed by #331
Assignees
Labels
bug Something isn't working

Comments

@naik-aakash
Copy link
Collaborator

naik-aakash commented Aug 12, 2024

After merging this materialsproject/pymatgen#3946 PR and a newer pymatgen release, calc quality analysis needs to be updated

@naik-aakash naik-aakash self-assigned this Aug 12, 2024
@JaGeo
Copy link
Owner

JaGeo commented Aug 12, 2024

You are invited to prepare both PRs. I will merge them

@JaGeo
Copy link
Owner

JaGeo commented Aug 12, 2024

Realated question: can you keepnthe pymatgen PR backward compatible?

@naik-aakash
Copy link
Collaborator Author

Realated question: can you keepnthe pymatgen PR backward compatible?

I notice, there was also overshadowed argument "type" in earlier implementation (now changed to fp_type), and also keeping backward compatibility is not possible and I did not think ahead when we wrote the code for DOS fingerprints and had added tanimoto arg as bool.

@naik-aakash
Copy link
Collaborator Author

You are invited to prepare both PRs. I will merge them

Yes, will do, but as mentioned, will wait for newer pymatgen release first 😃

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants