Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update calc quality and fingerprints usage #331

Merged
merged 11 commits into from
Sep 11, 2024

Conversation

naik-aakash
Copy link
Collaborator

@naik-aakash naik-aakash commented Sep 11, 2024

Closes #325

Changes

  1. DosFingerprints usage has been adapted to accommodate latest pymatgen changes
  2. pin pymatgen>=2024.9.10
  3. Remove redundant namedtuple instance of DosFingerprints from Lobsterpy (Has been moved to pymatgen in recent changes. See DOS Fingerprints enhancements materialsproject/pymatgen#3946)
  4. Drop python 3.9 support > pymatgen dropped it in its latest release
  5. Fix coverage not being uploaded. (issue : https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes , explicitly ignoring hidden files in uploads)

@naik-aakash naik-aakash marked this pull request as draft September 11, 2024 07:33
@naik-aakash naik-aakash changed the title Update calc quality and fingerprints usage [WIP] Update calc quality and fingerprints usage Sep 11, 2024
@naik-aakash naik-aakash self-assigned this Sep 11, 2024
@naik-aakash naik-aakash added the bug Something isn't working label Sep 11, 2024
@naik-aakash naik-aakash marked this pull request as ready for review September 11, 2024 10:43
@naik-aakash naik-aakash changed the title [WIP] Update calc quality and fingerprints usage Update calc quality and fingerprints usage Sep 11, 2024
@naik-aakash
Copy link
Collaborator Author

Hi @JaGeo, this PR is ready to be merged.

@JaGeo JaGeo merged commit a98d1be into JaGeo:main Sep 11, 2024
24 checks passed
@janosh
Copy link

janosh commented Sep 29, 2024

can we get a new release with these changes for materialsproject/atomate2#990. CI currently failing with

>               fp_lobster_orb = dos_lobster.get_dos_fp(
                    min_e=min_e,
                    max_e=max_e,
                    n_bins=n_bins,
                    normalize=True,
                    type=orb.name,
                )
E               TypeError: CompleteDos.get_dos_fp() got an unexpected keyword argument 'type'

@JaGeo
Copy link
Owner

JaGeo commented Sep 29, 2024

Yes, sure, we can. I thought we had taken care of it already. Sorry

@JaGeo
Copy link
Owner

JaGeo commented Sep 29, 2024

Should be done, @janosh .

@janosh
Copy link

janosh commented Sep 29, 2024

@JaGeo
Copy link
Owner

JaGeo commented Sep 29, 2024

Yeah. Saw it just now ....

@JaGeo
Copy link
Owner

JaGeo commented Sep 29, 2024

@janosh done. Release workflow still used Python 3.9... 😉

@naik-aakash
Copy link
Collaborator Author

Ops, I somehow overlooked that 😅

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calc quality analysis needs to be updated
3 participants