Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update BbTex key key in Fetch dialog is not displayed #1353

Closed
ghost opened this issue May 5, 2016 · 7 comments
Closed

Update BbTex key key in Fetch dialog is not displayed #1353

ghost opened this issue May 5, 2016 · 7 comments
Labels
[outdated] type: bug Confirmed bugs or reports that are very likely to be bugs

Comments

@ghost
Copy link

ghost commented May 5, 2016

JabRef version 3.3 and 3.4-master-2016-05-03 on Windows 10 x64 doen't update displayer BibTex key in DOI fetch dialog is not updated after clicking "Generate Now".

Steps to reproduce:

  1. Open Jabref
  2. Fetch Information by DOI
  3. Press "Generate now" button to update BibTex key
  4. Displayed BibTex Key should be updated to generated according to user preferences, but it's not. If the entry is saved now, it would contain updated key
@Siedlerchr
Copy link
Member

I can not reproduce this in the current master 1023c50
As far as I know there have been no recent changes on it.
Did you check the BibTexKey Generator Settings if they are correct?

I tried is using the following DOI: 10.2753/mis0742-1222280402:

  1. Fetch->DOI2BibTex
  2. jabreffetchdoi

The BibTex Key is in incorrect format Vlas_2012
3. Generate now
4. Save
The correct generated BibTex Key is displayed both in step 3 and step 4
jabreffetchdoi_correctkey
And importing the entry again, it is generated as Vlas2012a

@ghost
Copy link
Author

ghost commented May 5, 2016

I didn't notice that Bibtex key field. Please see red frames in attachments, the values there are inconsistent.
Fetch
untitled

Generate now
untitled1

@Siedlerchr
Copy link
Member

@vkoroteev Thanks for the information and the screenshots. So it is actually that the rendered preview does not get updated. I just confirmed your problem.

@tobiasdiez tobiasdiez added the [outdated] type: bug Confirmed bugs or reports that are very likely to be bugs label May 5, 2016
@ghost
Copy link
Author

ghost commented May 5, 2016

Hope this is easy to do :)

Siedlerchr added a commit to Siedlerchr/jabref that referenced this issue May 5, 2016
Fix for JabRef#1353
Fixed some missing unlocks
Some formatting
@Siedlerchr
Copy link
Member

@vkoroteev I just created a PR for this. 2 lines of code. Just a missing call to update the preview panel after generating the key.

Siedlerchr added a commit to Siedlerchr/jabref that referenced this issue May 8, 2016
Fix for JabRef#1353
Fixed some missing unlocks
Some formatting
Siedlerchr added a commit to Siedlerchr/jabref that referenced this issue May 11, 2016
Fix for JabRef#1353
Use locking with lock try unlock
Some formatting
Encapsulate frame in getter
tobiasdiez pushed a commit that referenced this issue May 12, 2016
Fix for #1353
Use locking with lock try unlock
Some formatting
Encapsulate frame in getter
@stefan-kolb
Copy link
Member

@Siedlerchr This one can be closed now?!

@Siedlerchr
Copy link
Member

@vkoroteev This fix has been included int he master, so it should be included in the most recent snapshot: http://builds.jabref.org/master/

@stefan-kolb Yes.

tschechlovdev pushed a commit to tschechlovdev/jabref that referenced this issue May 21, 2016
Fix for JabRef#1353
Use locking with lock try unlock
Some formatting
Encapsulate frame in getter
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
[outdated] type: bug Confirmed bugs or reports that are very likely to be bugs
Projects
None yet
Development

No branches or pull requests

4 participants