Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Allow selection of multiple groups #2786

Closed
tobiasdiez opened this issue Apr 23, 2017 · 7 comments
Closed

Allow selection of multiple groups #2786

tobiasdiez opened this issue Apr 23, 2017 · 7 comments

Comments

@tobiasdiez
Copy link
Member

tobiasdiez commented Apr 23, 2017

It was previously possible to select more then one group.

Related group settings:

  • "Intersection",
  • "Union",
  • "Inverted",
@AEgit
Copy link

AEgit commented Apr 23, 2017

I'm using this feature quite often, so I would heavily be in favour to it being readded.

@tobiasdiez tobiasdiez added this to the v4.0 milestone May 14, 2017
tobiasdiez added a commit that referenced this issue May 18, 2017
Implement #2786: Allow selection of multiple groups
@lenhard
Copy link
Member

lenhard commented May 18, 2017

This is implemented in #2845

@lenhard lenhard closed this as completed May 18, 2017
@AEgit
Copy link

AEgit commented May 18, 2017

I can confirm that this works in:
JabRef 4.0.0-dev--snapshot--2017-05-18--master--018173ebd

I do notice, however, that the group selection is somewhat slower compared to 3.8.2 - every time I select a group in the groups panel, it takes ~1-2 sec to show the group entries. In 3.8.2 this selection happened in an instant. This might be related to #2837 or #2588

@lenhard
Copy link
Member

lenhard commented May 19, 2017

Too bad. At least now much of the duplicated code is gone and I was hoping for a better performance. We should try to improve this some more before a final release.

@AEgit
Copy link

AEgit commented May 19, 2017

I might have to take it back. Today the performance issue I reported here, does not seem to appear. The group entries are shown immediately, when a group is selected. The only performance issue that remains is the one reported here:
#2588 (comment)

BTW: Can someone tell me, what the green colour around the item number reported next to each group in the groups panel means? Does it mean, that a selected entry is part of the group indicated in green? If so, I might have found another bug.

@tobiasdiez
Copy link
Member Author

@AEgit Yes, green = all selected entries are contained in this group, brownish green = at least one selected entry belongs to this group.

@AEgit
Copy link

AEgit commented May 21, 2017

@tobiasdiez : Thank you very much - I think I found the bug, I mentioned (it just took me a while to find out, how to replicate it): see #2857

Siedlerchr added a commit that referenced this issue May 27, 2017
* upstream/master: (23 commits)
  Implement #2785: resort groups using drag & drop (#2864)
  Add Library of Congress as ID-fetcher (#2865)
  Fix export and import of MS office day/year/month acessed fields (#2862)
  Adsurl to url (#2861)
  Update LICENSE.md
  Update
  Update LICENSE.md
  Update license file so that github recognize it properly
  Improve Issue Template Using a Collapsible Log Area
  Fix #2852: Improve performance of group filtering.
  Rename GroupSelector to GroupSidePane
  Fix #2843: Show information correctly in entry editor
  Remove old entry editor code related to focus selection
  Implement feedback
  Menu Greek Translation (#2836)
  Relaxed the regex to also match negative timezone formats when parsing pdf annotation dates (#2841)
  Update localization
  Remove unnecessary group code (and move remaining settings to preferences)
  Add Local Maven repo as first lookup resource, to avoid having duplicate libs in gradle and maven
  Implement #2786: Allow selection of multiple groups
  ...
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants