Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fetcher isbn exception when including linebreak #6456

Closed
ilippert opened this issue May 10, 2020 · 1 comment · Fixed by #7023
Closed

fetcher isbn exception when including linebreak #6456

ilippert opened this issue May 10, 2020 · 1 comment · Fixed by #7023
Labels
component: entry-editor component: fetcher

Comments

@ilippert
Copy link
Contributor

JabRef 5.1-PullRequest6455.368--2020-05-09--fff4926
Linux 5.6.8-200.fc31.x86_64 amd64
Java 14.0.1

When I add a linebreak (enter) to an ISBN field and then click onto retrieve metadata, i get the exception

Steps to reproduce the behavior:

  1. use isbn number with linebreak
  2. retrieve metadata

Suggestion:

  • before fetching isbn data, remove linebreaks
  • isbn number followed by pressing enter should not generate linebreak but open the isbn (or alternatively ask whether to open or retrieve metadata).
Log File

org.jabref.logic.importer.FetcherException: Could not
at org.jabref/org.jabref.logic.importer.fetcher.IsbnViaOttoBibFetcher.performSearchById(IsbnViaOttoBibFetcher.java:58)
at org.jabref/org.jabref.logic.importer.fetcher.IsbnFetcher.performSearchById(IsbnFetcher.java:55)
at org.jabref/org.jabref.gui.mergeentries.FetchAndMergeEntry.lambda$fetchAndMerge$0(FetchAndMergeEntry.java:65)
at org.jabref/org.jabref.gui.util.BackgroundTask$1.call(BackgroundTask.java:47)
at org.jabref/org.jabref.gui.util.DefaultTaskExecutor$1.call(DefaultTaskExecutor.java:142)
at org.jabref.merged.module/javafx.concurrent.Task$TaskCallable.call(Task.java:1425)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1130)
at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:630)
at java.base/java.lang.Thread.run(Thread.java:832)
Caused by: java.net.MalformedURLException: Illegal character in URL
at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.checkURL(HttpsURLConnectionImpl.java:70)
at java.base/sun.net.www.protocol.https.HttpsURLConnectionImpl.(HttpsURLConnectionImpl.java:81)
at java.base/sun.net.www.protocol.https.Handler.openConnection(Handler.java:62)
at java.base/sun.net.www.protocol.https.Handler.openConnection(Handler.java:57)
at java.base/java.net.URL.openConnection(URL.java:1101)
at org.jabref.merged.module/org.jsoup.helper.HttpConnection$Response.createConnection(HttpConnection.java:892)
at org.jabref.merged.module/org.jsoup.helper.HttpConnection$Response.execute(HttpConnection.java:729)
at org.jabref.merged.module/org.jsoup.helper.HttpConnection$Response.execute(HttpConnection.java:707)
at org.jabref.merged.module/org.jsoup.helper.HttpConnection.execute(HttpConnection.java:297)
at org.jabref.merged.module/org.jsoup.helper.HttpConnection.get(HttpConnection.java:286)
at org.jabref/org.jabref.logic.importer.fetcher.IsbnViaOttoBibFetcher.performSearchById(IsbnViaOttoBibFetcher.java:56)
... 11 more
@joethei joethei mentioned this issue Oct 16, 2020
Merged
5 tasks
Siedlerchr pushed a commit that referenced this issue Oct 17, 2020
@joethei
remove any newlines and spaces in isbn when fetching (#7023)
0ef37d8 
* remove any newlines and spaces in isbn when fetching
Fixes #6456

* Update IsbnFetcher.java

* Update CHANGELOG.md

* remove duplicate changelog entry
@Siedlerchr
Copy link
Member

Thankst to @joethei this should now be fixed in the latest development version

koppor pushed a commit that referenced this issue Apr 1, 2023
Squashed 'buildres/csl/csl-styles/' changes from ca943b70d7..41531558a8
88e335d 
41531558a8 Fix unsigned newspaper articles throughout Chicago 17 (#6486)
7678212826 Create trames.csl (#6479)
0cae26ac85 Update hochschule-fur-soziale-arbeit-fhnw.csl (#6480)
85c4b693a2 Update to UP Harvard Theology & Religion (#6485)
c273aa7e43 Update ieee.csl (#6481)
fe67b80e47 Update open-window.csl (#6367)
f2229705ef Create iainutuban-tarbiyah.csl (#6361)
1867a56a26 Create business-and-human-rights-journal (#6359)
1371dbdf26 Update iso690-author-date-es.csl (#6477)
6953a43efd Update ieee.csl (#6478)
f56d5ef1cc Create czech-journal-of-international-relations.csl (#6453)
678b53f99c Update harvard-stellenbosch-university.csl (#6464)
3074938038 Update ucl-university-college-apa.csl (#6475)
27dab9ea0f Update iso690-author-date-es.csl (#6476)
a8aea63d00 Create elsevier-american-chemical-society.csl (#6342)
f8f290fa63 Update iso690-author-date-es.csl (#6472)
7fdc621eee Update journal-of-neolithic-archaeology (#6466)
7025568e70 Update offa.csl (#6465)
2d69299b19 Create uni-fribourg-theologie.csl (#6473)
8db531a73e Create travail-et-emploi.csl (#6351)
c8b54fc531 Make monash-university-harvard dependent style (#6470)
b95f59ff5c Update journal-of-the-marine-biological-association-of-the-united-kingdom.csl (#6456)
a12b513119 Update universite-du-quebec-a-montreal.csl (#6463)
048e6641e4 Update zeitschrift-fur-geschichtsdidaktik.csl (#6454)
f0d3d7ef15 Update journal-fur-kulturpflanzen-journal-of-cultivated-plants.csl (#6447)
3b814fe048 Update the-accounting-review.csl (#6459)
f24befd580 Update survey-of-ophthalmology.csl from ama.csl to its own independent style (#6460)
c868ab54f6 Create vancouver-alphabetical.csl (#6461)
782e39cfe1 Update american-institute-of-physics.csl (#6457)
a56cf03e3c Fix Chicago Cases & Newspaper sorting (#6458)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 41531558a873b2533f2d17d8d6484c2408174fce
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
component: entry-editor component: fetcher
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove any newlines and spaces in isbn when fetching
2 participants
@Siedlerchr @ilippert