Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use .COMMENT instead of outdated .REVIEW #10478

Merged
merged 4 commits into from
Oct 11, 2023
Merged

Use .COMMENT instead of outdated .REVIEW #10478

merged 4 commits into from
Oct 11, 2023

Conversation

koppor
Copy link
Member

@koppor koppor commented Oct 10, 2023

The ISI importer used the .REVIEW field which we migrate away on load.

Refs #10370

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Siedlerchr
Siedlerchr reviewed Oct 10, 2023
View reviewed changes
koppor and others added 2 commits October 10, 2023 23:28
@koppor @Siedlerchr
Update CHANGELOG.md
9f1f394 
Co-authored-by: Christoph <siedlerkiller@gmail.com>
@koppor
Update CHANGELOG.md
7ec949f
@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 11, 2023 •
edited
Loading

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

@calixtus calixtus added this pull request to the merge queue Oct 11, 2023
Merged via the queue into main with commit 6163b63 Oct 11, 2023
@calixtus calixtus deleted the use-comment branch October 11, 2023 22:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr left review comments

@calixtus calixtus calixtus approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koppor @Siedlerchr @calixtus