Upgrade to StAX parsing for CSL style titles #11604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subhramit
changed the title
Siedlerchr
reviewed
Aug 10, 2024
|
lgtm |
Siedlerchr
previously approved these changes
Aug 10, 2024
|
please reset the submodules... |
done |
Siedlerchr
approved these changes
Aug 11, 2024
|
in your next PR cou can also add a unit test for this |
6 tasks
will do. |
6 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Subsidiary PR for the GSoC '24 CSL4LibreOffice Project]
Upgrade parser of CSL style titles from DOM to StAX
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)Tests created for changes (if applicable)Screenshots added in PR description (for UI changes)