Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Auto-sync CSL Bibliography feature #11683

Merged
merged 4 commits into from
Aug 29, 2024
Merged

Auto-sync CSL Bibliography feature #11683

merged 4 commits into from
Aug 29, 2024

Conversation

subhramit
Copy link
Member

@subhramit subhramit commented Aug 27, 2024

Closes subhramit#26
Follow-up to: #11577

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@subhramit subhramit changed the title Auto-update CSL Bibliography feature CSL4LibreOffice - Auto-update CSL Bibliography feature Aug 27, 2024
@subhramit
Copy link
Member Author

subhramit commented Aug 27, 2024

Note that this feature does not work for JStyles, and not as a consequence of any change made during the CSL4LibreOffice project. [Tested using JabRef 5.13 stable]
We will need to fix this for JStyles separately. I have filed an issue (#11684).
I did not fix it in this PR as it will require diving slightly deeper on how syncOptions are used - the code for JStyles is, as usual, more complex.

I wanted it to at least be there for CSL for the 6.0-alpha version.

@subhramit subhramit added this to the 6.0-alpha milestone Aug 27, 2024
@subhramit subhramit changed the title CSL4LibreOffice - Auto-update CSL Bibliography feature Auto-update CSL Bibliography feature Aug 28, 2024
@subhramit subhramit requested review from Siedlerchr and koppor August 28, 2024 00:59
@Siedlerchr Siedlerchr added this pull request to the merge queue Aug 29, 2024
Merged via the queue into JabRef:main with commit 70d7c9c Aug 29, 2024
22 checks passed
@Siedlerchr Siedlerchr deleted the csl branch August 29, 2024 20:31
@ThiloteE
Copy link
Member

I approve too.

@subhramit subhramit changed the title Auto-update CSL Bibliography feature Auto-sync CSL Bibliography feature Aug 30, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Settings > Sync bibliography work with CSL
3 participants