Fixed #1245 #1246
Merged
Fixed #1245 #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
added
[outdated] type: bug
|
LGTM but can you please add a test for the fix. |
|
Yes, but not right now. Good point!
|
|
Could you please add a test for it so we can merge this in 😄 ? We already closed the related issue. |
|
Done! Will merge when I see that the tests pass. |
| @@ -494,4 +494,26 @@ public void testCompareToNotEqual() throws IOException { | |||
| assertTrue(style1.compareTo(style2) > 0); | |||
| assertFalse(style2.compareTo(style1) > 0); | |||
| } | |||
|
|
|||
|
|
|||
| public void test1245AndOxfordComma() throws URISyntaxException, IOException { | |||
There was a problem hiding this comment.
Dont call it 1245 please 😄 Name it by what it does check.
There was a problem hiding this comment.
Yeah, I do not really know what it checks. ;-) (But I'll figure something out.)
There was a problem hiding this comment.
Something with empty strings as values?! maybe the oxford comma is even a separate test case?
There was a problem hiding this comment.
I was considering a separate test case, but it would (could) look exactly the same, so I thought it made more sense to have both in one.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1245 so that it is possible to set empty strings is jstyle-files as
key=""