-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Disable connect button when connecting. #1839
Conversation
LGTM 👍 |
@@ -90,13 +90,16 @@ public OpenSharedDatabaseDialog(JabRefFrame frame) { | |||
} | |||
|
|||
public void openSharedDatabase() { | |||
setLoadingConnectButton(true); | |||
|
|||
try { | |||
bibDatabaseContext.getDBSynchronizer().openSharedDatabase(connectionProperties); | |||
frame.addTab(bibDatabaseContext, true); | |||
setGlobalPrefs(); | |||
bibDatabaseContext.getDBSynchronizer().registerListener(new SharedDatabaseUIManager(frame)); | |||
frame.output(Localization.lang("Connection_to_%0_server_stablished.", connectionProperties.getType().toString())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, but I couldn't help to notice "stablished" which should be "established".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, yes. Done.
Looks good! Had to think a bit to understand why you return before getting the button back to normal. :-) |
c521f61
to
cee10f4
Compare
@@ -2473,3 +2473,6 @@ Entered_database_has_obsolete_structure_and_is_no_longer_supported.=Die_gewählt | |||
However,_a_new_database_was_created_alongside_the_pre-3.6_one.=Dennoch_wurde_eine_neue_Datenbank_neben_der_alten_Datenbank_erzeugt. | |||
|
|||
Click_here_to_learn_about_the_migration_of_pre-3.6_databases.=Klicken_um_Informationen_zur_Migration_von_vor-3.6-Datenbanken_zu_erhalten. | |||
Click_here_to_learn_about_the_migration_of_pre-3.6_databases.= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Please fix minor comments, resolve conflicts and take care that no duplicate localizations come in. Then, it's good to go. |
cee10f4
to
6036afb
Compare
@@ -1711,3 +1711,6 @@ Entered_database_has_obsolete_structure_and_is_no_longer_supported.=Cette_base_d | |||
However,_a_new_database_was_created_alongside_the_pre-3.6_one.=Ainsi,_une_nouvelle_base_a_été_créée_en_parallèle_de_celle_antérieure_à_la_version_3.6. | |||
|
|||
Click_here_to_learn_about_the_migration_of_pre-3.6_databases.=Cliquer_ici_pour_plus_de_détails_sur_la_migration_des_bases_antérieures_à_la_version_3.6. | |||
Click_here_to_learn_about_the_migration_of_pre-3.6_databases.= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duplicate here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. (it comes from auto-merge)
6036afb
to
7714595
Compare
* Disable connect button when connecting. * Fix minor issues.
Issue: #1703.