Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Disable connect button when connecting. #1839

Merged
merged 2 commits into from
Aug 25, 2016

Conversation

obraliar
Copy link
Contributor

Issue: #1703.

"open remote database dialog": "Connect" button should be disabled an label change to "Connecting...". Reason: Connection may take longer and pressing the button multiple times leads to error message dialogs. (You know, http://www.freemysqlhosting.net/ latency)

  • Manually tested changed features in running JabRef

@obraliar obraliar changed the title Disable connect button when connecting. [WIP] Disable connect button when connecting. Aug 24, 2016
@boceckts
Copy link
Contributor

LGTM 👍

@boceckts boceckts added status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers and removed stupro-ready-for-internal-review labels Aug 24, 2016
@boceckts boceckts changed the title [WIP] Disable connect button when connecting. Disable connect button when connecting. Aug 24, 2016
@@ -90,13 +90,16 @@ public OpenSharedDatabaseDialog(JabRefFrame frame) {
}

public void openSharedDatabase() {
setLoadingConnectButton(true);

try {
bibDatabaseContext.getDBSynchronizer().openSharedDatabase(connectionProperties);
frame.addTab(bibDatabaseContext, true);
setGlobalPrefs();
bibDatabaseContext.getDBSynchronizer().registerListener(new SharedDatabaseUIManager(frame));
frame.output(Localization.lang("Connection_to_%0_server_stablished.", connectionProperties.getType().toString()));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, but I couldn't help to notice "stablished" which should be "established".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, yes. Done.

@oscargus
Copy link
Contributor

Looks good! Had to think a bit to understand why you return before getting the button back to normal. :-)

@obraliar obraliar force-pushed the ConnectionFeedback branch 2 times, most recently from c521f61 to cee10f4 Compare August 24, 2016 22:23
@koppor koppor added this to the v3.6 milestone Aug 25, 2016
@@ -2473,3 +2473,6 @@ Entered_database_has_obsolete_structure_and_is_no_longer_supported.=Die_gewählt
However,_a_new_database_was_created_alongside_the_pre-3.6_one.=Dennoch_wurde_eine_neue_Datenbank_neben_der_alten_Datenbank_erzeugt.

Click_here_to_learn_about_the_migration_of_pre-3.6_databases.=Klicken_um_Informationen_zur_Migration_von_vor-3.6-Datenbanken_zu_erhalten.
Click_here_to_learn_about_the_migration_of_pre-3.6_databases.=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@koppor
Copy link
Member

koppor commented Aug 25, 2016

Please fix minor comments, resolve conflicts and take care that no duplicate localizations come in. Then, it's good to go.

@obraliar obraliar force-pushed the ConnectionFeedback branch from cee10f4 to 6036afb Compare August 25, 2016 13:00
@@ -1711,3 +1711,6 @@ Entered_database_has_obsolete_structure_and_is_no_longer_supported.=Cette_base_d
However,_a_new_database_was_created_alongside_the_pre-3.6_one.=Ainsi,_une_nouvelle_base_a_été_créée_en_parallèle_de_celle_antérieure_à_la_version_3.6.

Click_here_to_learn_about_the_migration_of_pre-3.6_databases.=Cliquer_ici_pour_plus_de_détails_sur_la_migration_des_bases_antérieures_à_la_version_3.6.
Click_here_to_learn_about_the_migration_of_pre-3.6_databases.=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicate here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. (it comes from auto-merge)

@obraliar obraliar force-pushed the ConnectionFeedback branch from 6036afb to 7714595 Compare August 25, 2016 13:22
@matthiasgeiger matthiasgeiger merged commit 0701168 into JabRef:master Aug 25, 2016
ayanai1 pushed a commit to ayanai1/jabref that referenced this pull request Sep 5, 2016
* Disable connect button when connecting.

* Fix minor issues.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants