-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
NameChange and update to JabRef4 #4232
Conversation
1)The name has to be changed because otherwise on Ubuntu it will appear twice in activities: once the icon added to favourites and once the opened instance, see https://unix.stackexchange.com/a/59654/241592 for details. The name has to be identical with the Application. 2)Since Ubuntu 18.04 uses JabRef3, which ruins the grouping of JabRef4, just by starting JabRef! (automatic opening last files and autosave?!?), you should use JabRef4 using java -jar ~/${[[:Folder To Your Jabref:]]}/JabRef-4.3.1.jar For more details see (Only for the germans developers): https://wiki.ubuntuusers.de/JabRef/ (which should be updated (I think that's the first place to search for Germanspeakings), it says the newest 2.9 version can be installed using sourceforge, maybe you should refer to http://help.jabref.org/en/Installation, which might also should be updated to Ubuntu 18.04.) 3) The icon does not work You might should specify that it should be downloaded from: https://github.com/JabRef/jabref/blob/master/src/main/resources/images/external/JabRef-icon-128.png and should be stored f.e. in ~/.local/share/icons/
Thanks for your contribution! If you have some more experiences regarding Ubuntu and snaps, you can find some other open points which need to be tackled in #3121 |
Sorry the 1) The filename (name of the file before *.desktop), the 2) the "Name" and 3) the Application have to have the identical name
@koppor can you please have a look at this PR. Thanks! |
I am not sure how this PR relates to the snap build. The place holder I need more explanation, what this thing does. Maybe a PR on our installation instructions at https://github.com/JabRef/help.jabref.org/blob/gh-pages/en/Installation.md would help.
@JoKalliauer could you please take care about the installation instructions? You can assume your PR here is merged in that case. |
Hey @JoKalliauer 👋 can you have a look at the comments and adapt the code so we can move forward with this PR? |
@LinusDietz : Thanks for reminding! If I install jabref according to |
You are correct. We only provide the standalone jar file for linux. No *deb package and therfore no icon. and the snap package was a promising idea, but it turns out that the build process is still complex and there need to be some issues resolved on the Linux/Ubuntu side which we can't do anyhting about atm. Either you adapt your code and maybe you can solve that or we decide to close the PR. |
Maybe we should close this pull request. |
The name has to be changed because otherwise on Ubuntu it will appear twice in activities: once the icon added to favourites and once the opened instance, see https://unix.stackexchange.com/a/59654/241592 for details. The name has to be identical with the Application.
Since Ubuntu 18.04 uses JabRef3, which ruins the grouping of JabRef4, just by starting JabRef! (automatic opening last files and autosave?!?), you should use JabRef4 using java -jar ~/${[[:Folder To Your Jabref:]]}/JabRef-4.3.1.jar
For more details see (Only for the germans developers): https://wiki.ubuntuusers.de/JabRef/ (which should be updated (I think that's the first place to search for Germanspeakings), it says the newest 2.9 version can be installed using sourceforge, maybe you should refer to http://help.jabref.org/en/Installation, which might also should be updated to Ubuntu 18.04.)
The icon does not work
You might should specify that it should be downloaded from:
https://github.com/JabRef/jabref/blob/master/src/main/resources/images/external/JabRef-icon-128.png
and should be stored f.e. in ~/.local/share/icons/