Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

NameChange and update to JabRef4 #4232

Closed
wants to merge 2 commits into from
Closed

NameChange and update to JabRef4 #4232

wants to merge 2 commits into from

Conversation

JoKalliauer
Copy link
Contributor

  1. The name has to be changed because otherwise on Ubuntu it will appear twice in activities: once the icon added to favourites and once the opened instance, see https://unix.stackexchange.com/a/59654/241592 for details. The name has to be identical with the Application.

  2. Since Ubuntu 18.04 uses JabRef3, which ruins the grouping of JabRef4, just by starting JabRef! (automatic opening last files and autosave?!?), you should use JabRef4 using java -jar ~/${[[:Folder To Your Jabref:]]}/JabRef-4.3.1.jar
    For more details see (Only for the germans developers): https://wiki.ubuntuusers.de/JabRef/ (which should be updated (I think that's the first place to search for Germanspeakings), it says the newest 2.9 version can be installed using sourceforge, maybe you should refer to http://help.jabref.org/en/Installation, which might also should be updated to Ubuntu 18.04.)

  3. The icon does not work
    You might should specify that it should be downloaded from:
    https://github.com/JabRef/jabref/blob/master/src/main/resources/images/external/JabRef-icon-128.png
    and should be stored f.e. in ~/.local/share/icons/


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

1)The name has to be changed because otherwise on Ubuntu it will appear twice in activities: once the icon added to favourites and once the opened instance, see https://unix.stackexchange.com/a/59654/241592 for details. The name has to be identical with the Application.

2)Since Ubuntu 18.04 uses JabRef3, which ruins the grouping of JabRef4, just by starting JabRef! (automatic opening last files and autosave?!?), you should use JabRef4 using java -jar ~/${[[:Folder To Your Jabref:]]}/JabRef-4.3.1.jar
For more details see (Only for the germans developers): https://wiki.ubuntuusers.de/JabRef/ (which should be updated (I think that's the first place to search for Germanspeakings), it says the newest 2.9 version can be installed using sourceforge, maybe you should refer to http://help.jabref.org/en/Installation, which might also should be updated to Ubuntu 18.04.)

3) The icon does not work
You might should specify that it should be downloaded from:
https://github.com/JabRef/jabref/blob/master/src/main/resources/images/external/JabRef-icon-128.png
and should be stored f.e. in ~/.local/share/icons/
@Siedlerchr
Copy link
Member

Thanks for your contribution! If you have some more experiences regarding Ubuntu and snaps, you can find some other open points which need to be tackled in #3121

Sorry the 1) The filename (name of the file before *.desktop), the 2) the "Name" and 3) the Application have to have the identical name
@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Aug 2, 2018
@tobiasdiez
Copy link
Member

@koppor can you please have a look at this PR. Thanks!

@koppor
Copy link
Member

koppor commented Oct 10, 2018

I am not sure how this PR relates to the snap build. The place holder SNAP is still in there, but there seems to be a manual place holder ({[[:Folder To Your Jabref:]]}). So, this doesn't seem to fully work.

I need more explanation, what this thing does. Maybe a PR on our installation instructions at https://github.com/JabRef/help.jabref.org/blob/gh-pages/en/Installation.md would help.

  • Add an ADR on the name. Otherwise, it's a WTF when looking at the name field.
  • It seems that {[[:Folder To Your Jabref:]]} raises some input field. I would like to see some automatic installation here. At least, some improvements in our installation description.
  • The icon is still an open issue.
  • Ubuntu Wiki page needs to be updated. We do not maintain it for ourselves, but the Ubuntu user community does it.

@JoKalliauer could you please take care about the installation instructions? You can assume your PR here is merged in that case.

@koppor koppor removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Oct 10, 2018
@LinusDietz
Copy link
Member

Hey @JoKalliauer 👋 can you have a look at the comments and adapt the code so we can move forward with this PR?

@JoKalliauer
Copy link
Contributor Author

@LinusDietz : Thanks for reminding!

If I install jabref according to
https://github.com/JabRef/help.jabref.org/blob/gh-pages/en/Installation.md
I only install java, but I only execute a portable jabref (without creating any jabref.desktop-icon).
Is that correct?
I don't see the installation instruction for JabRef.
Maybe I missed/forget something.

@Siedlerchr
Copy link
Member

Siedlerchr commented Dec 28, 2018

@LinusDietz : Thanks for reminding!

If I install jabref according to
https://github.com/JabRef/help.jabref.org/blob/gh-pages/en/Installation.md
I only install java, but I only execute a portable jabref (without creating any jabref.desktop-icon).
Is that correct?
I don't see the installation instruction for JabRef.
Maybe I missed/forget something.

You are correct. We only provide the standalone jar file for linux. No *deb package and therfore no icon. and the snap package was a promising idea, but it turns out that the build process is still complex and there need to be some issues resolved on the Linux/Ubuntu side which we can't do anyhting about atm. Either you adapt your code and maybe you can solve that or we decide to close the PR.

@Siedlerchr Siedlerchr added the status: waiting-for-feedback The submitter or other users need to provide more information about the issue label Dec 28, 2018
@JoKalliauer
Copy link
Contributor Author

Either you adapt your code and maybe you can solve that or we decide to close the PR.

Maybe we should close this pull request.

@koppor koppor self-assigned this Mar 12, 2019
@koppor koppor added the freeze label Mar 12, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
dev: build-system platform: linux status: waiting-for-feedback The submitter or other users need to provide more information about the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants