Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix the 'Attach file' dialog for starting on the user's main directory #4996

Merged
merged 1 commit into from
May 26, 2019
Merged

Fix the 'Attach file' dialog for starting on the user's main directory #4996

merged 1 commit into from
May 26, 2019

Conversation

davidemdot
Copy link
Member

Now the "Attach file" dialog, in the right-click menu for an entry, starts on the working directory instead of the user's main directory. It is the same behavior as when adding a file from the entry editor.

It solves #4995

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

tobiasdiez
tobiasdiez approved these changes May 26, 2019
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Siedlerchr Siedlerchr merged commit 0f8795b into JabRef:master May 26, 2019
Siedlerchr added a commit that referenced this pull request May 26, 2019
@Siedlerchr
Merge branch 'ieeFix' of github.com:JabRef/jabref into ieeFix
62553de 
* 'ieeFix' of github.com:JabRef/jabref:
  Fix the 'Attach file' dialog for starting on the user's main directory (#4996)
  Readme TOC (#4986)
  Fix icon size - the second (#4993)
  Fix background color of dialogs in dark mode (#4994)
  NPE-fix for Preferences/Ext-Prog/Settings for X/Browse  (#4983)
  Bump richtextfx from 0.10.0 to 0.10.1 (#4989)
  Bump tika-core from 1.20 to 1.21 (#4984)
  Resize different fonts changing entry type (#4980)
  Extended Hints - Alternative to #4971 (#4975)
  Fix command line help text (#4979)
Siedlerchr added a commit that referenced this pull request May 27, 2019
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into convertSearchWorker
1c675db 
* upstream/master:
  Update mac icon and install4j to 7.0.11 (#5005)
  Bump checkstyle from 8.20 to 8.21 (#5001)
  fix IEE fetcher (#4999)
  Fix the 'Attach file' dialog for starting on the user's main directory (#4996)
  Readme TOC (#4986)
@davidemdot davidemdot deleted the fix-add-file-entry-main-dir branch July 27, 2019 15:23
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

@tobiasdiez tobiasdiez tobiasdiez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidemdot @Siedlerchr @tobiasdiez