Conversion of preferencesDialog/advancedTab, networkTab and groupsTab to mvvm #5141
Conversation
calixtus
changed the title
|
Sorry for this large PR. Besides the conversion/merge of the three tabs to mvvm, mainly small corrections and cosmetics I overlooked earlier. |
src/main/java/org/jabref/gui/preferences/AdvancedTabViewModel.java
Outdated
Show resolved
Hide resolved
| Network=Network | ||
| Please\ specify\ both\ hostname\ and\ port=Please specify both hostname and port | ||
| Please\ specify\ both\ username\ and\ password=Please specify both username and password | ||
| Search\ IEEEXplore=Search IEEEXplore |
There was a problem hiding this comment.
Normally it should be sufficient to have the Search %0. It would be interesting to see if this works in fxml somewhow.
There was a problem hiding this comment.
I tried around a little bit, but I could not find a real solution. The problem is in mixing Ressource-Resolution and dynamic binding in one property. The other option would be to put setText(Localization.lang("Search %0") + "IEEExplore") into the Java-View.
One thing i principally thought of: The term "Search" can have multiple translations. In this case, its a header. "Search IEEExplore" would probably translated into german into "Suche in IEEExplore". If we use "Search %0" here und want to use it e.g. for a search in the entries, you probably say in german "Suche nach %0"
|
I made an abstract-class to stop repeating the the getBuilder-stuff on every tab and reworded the abbreviated PrefsTab-Interface, so this is why this PR grew again. |
…ced_mvvm # Conflicts: # src/main/java/org/jabref/gui/icon/IconTheme.java
|
Huh, travis failed because some github service was not available. However, works fine on my machine. I would really love to get some reply on my thoughts two weeks ago and how I should proceed... |
Siedlerchr
added
the
status: ready-for-review
|
Sorry, I was away the whole last week,but codewise looks good to me. Was there anything else you wanted to know? |
|
No panic 😄, I just wanted to know, if I should change the "Search IEEExplore" localization back to "Search %0" |
|
No, you can leave it, I tried to find a solution but seems there is not one for the fxml stuff. |
|
ok, I'll leave it than that way. |
|
Looks good, can this be merged now? |
|
sure |
* upstream/master: Bugfix/5045 : Modified the existing logic to comply crossref resolution with biblatex specification (JabRef#5086) Fix issue with missing year value in year column (JabRef#5197) Bump com.gradle.build-scan from 2.4 to 2.4.1 (JabRef#5199) Add citation commands to TexParser: autocite, blockcquote, and textcquote (JabRef#5195) Conversion of preferencesDialog/advancedTab, networkTab and groupsTab to mvvm (JabRef#5141) Fix Permissions of LaTeXintegration (JabRef#5134) Border for group color indicator and some space for tooltip (JabRef#5190) Fix issue 5152, tooltip and icon added to group cell (JabRef#5191) Fix tooltips in CitationsDisplay (JabRef#5188)
follow-up to #5033
The next tab, this time advancedTab and networkTab combined
Also conversion of the groupsTab and some minor refactoring