Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Set BibEntry to "changed" state before setting a new entry type #5966

Merged
merged 2 commits into from
Feb 21, 2020
Merged

Set BibEntry to "changed" state before setting a new entry type #5966

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d08b1f8
Fix: setting BibEntry to "changed" state before setting a new entry type
dawidm Feb 20, 2020
6724f82
Update changelog
dawidm Feb 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/org/jabref/model/entry/BibEntry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,8 +359,8 @@ public Optional<FieldChange> setType(EntryType newType, EntriesEventSource event
return Optional.empty();
}

this.type.setValue(newType);
changed = true;
this.type.setValue(newType);

FieldChange change = new FieldChange(this, InternalField.TYPE_HEADER, oldType.getName(), newType.getName());
eventBus.post(new FieldChangedEvent(change, eventSource));
Expand Down