Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix #6530 #6556

Closed
wants to merge 1 commit into from
Closed

Fix #6530 #6556

wants to merge 1 commit into from

Conversation

libkoi
Copy link

@libkoi libkoi commented May 30, 2020

Fix #6530
Add judge branch for "doi" input. RegEx adapted from wikidata.

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@Siedlerchr
Copy link
Member

Sorry, but I think @braincident was earlier with his/her PR for the issue and the solution he/she has looks a bit better as we already have a DOI class which handles parsing of DOIs. So the regex would have not been necessary

@Siedlerchr Siedlerchr closed this May 30, 2020
@libkoi libkoi deleted the fix-6530 branch May 31, 2020 07:22
koppor pushed a commit that referenced this pull request Jun 1, 2023
6b7fdff8cb Create journal-of-the-american-philosophical-association.csl (#6542)
9bae9efc55 Update german-council-of-economic-experts.csl (#6562)
256250be9c Update springer-vancouver-brackets.csl (#6546)
f422ca9c9a Update turabian-fullnote-bibliography.csl (#6540)
2833b5d5d5 Update mots.csl (#6556)
44758704b0 Update and rename harvard-the-university-of-melbourne.csl to dependen… (#6547)
08e65fc8e1 Update ieee-with-url.csl (#6514)
06e98f4387 Fix erroneous comma in ACL in-text citation (#6553)
72e16a19cd Update bibliothek-forschung-und-praxis.csl (#6527)
50bae82394 Create Food and Agriculture Organization of the United Nations (numeric) (#6544)
234a3c35d8 Update bern-university-of-applied-sciences-school-of-agricultural-for… (#6552)
3e9e2d6e93 Fix et al and name settings in universitat bern institut fur sozialanthropologie (#6554)
e8e06888fe Update harvard-university-of-the-west-of-england.csl (#6520)
dbbe5c1a95 Update united-states-international-trade-commission.csl (#6535)
b985431f03 Update american-society-for-horticultural-science.csl (#6543)
e1ff9f5546 Sort APA and derivatives on displayed date, not full date (#6545)
7302832d6d Localize original-work-published in APA (#6388)
77a61c0d82 Update united-states-international-trade-commission.csl (#6526)
541807a057 Update the-accounting-review.csl (#6521)
708626357a  Update united-states-international-trade-commission

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 6b7fdff8cb0fb45b342e8ac319634bf18168c73d
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DOI not imported from RIS file
2 participants