Add Collection of Comp Sci Bibliographies fetcher #6664

daniel-price · 2020-07-01T14:45:27Z

Change in CHANGELOG.md described (if applicable)
Tests created for changes (if applicable)
Manually tested changed features in running JabRef (always required)
Screenshots added in PR description (for UI changes)
Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

...java/org/jabref/logic/importer/fetcher/CollectionOfComputerScienceBibliographiesFetcher.java

koppor

Thank you for working on this. It is a tough task since JabRef focuses on high code quality AND on high quality of BibTeX entries (as much as work should be done by JabRef automatically; the user should not be forced to spend any time to improve the quality of the BibTeX entries).

Thus, I gave two kinds of comments:

nitpicks to the code style
questions to the fetcher logic. Especially, because a) not all fields available are returned and b) dblp offers a BibTeX result (and it was not clear to my why this result is not used).

CHANGELOG.md

...java/org/jabref/logic/importer/fetcher/CollectionOfComputerScienceBibliographiesFetcher.java

.../java/org/jabref/logic/importer/fetcher/CollectionOfComputerScienceBibliographiesParser.java

.../org/jabref/logic/importer/fetcher/CollectionOfComputerScienceBibliographiesFetcherTest.java

...rter/fetcher/collection_of_computer_science_bibliographies_multiple_results_first_result.bib

...abref/logic/importer/fetcher/collection_of_computer_science_bibliographies_single_result.bib

...abref/logic/importer/fetcher/collection_of_computer_science_bibliographies_single_result.xml

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>

…es' of https://github.com/daniel-price/jabref into new-fetcher-collection-of-computer-science-bibliographies

…-bibliographies

…es' of https://github.com/daniel-price/jabref into new-fetcher-collection-of-computer-science-bibliographies

…-bibliographies

.../org/jabref/logic/importer/fetcher/CollectionOfComputerScienceBibliographiesFetcherTest.java

…es' of https://github.com/daniel-price/jabref into new-fetcher-collection-of-computer-science-bibliographies

koppor

I like the added test.

Unfortunately, it shows that the abstract has some unnecessary whitespace. Could you maybe adress this?

.../org/jabref/logic/importer/fetcher/CollectionOfComputerScienceBibliographiesFetcherTest.java

...a/org/jabref/logic/importer/fetcher/CollectionOfComputerScienceBibliographiesParserTest.java

...jabref/logic/importer/fetcher/collection_of_computer_science_bibliographies_empty_result.xml

...abref/logic/importer/fetcher/collection_of_computer_science_bibliographies_single_result.bib

…mputerScienceBibliographiesParserTest.java Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>

...ef/logic/importer/fetcher/collection_of_computer_science_bibliographies_multiple_results.xml

…es' of https://github.com/daniel-price/jabref into new-fetcher-collection-of-computer-science-bibliographies

koppor

That was fast - thank you. Little nitpick remaining 😇

src/main/java/org/jabref/logic/formatter/bibtexfields/RemoveTabsFormatter.java

src/main/java/org/jabref/logic/formatter/bibtexfields/RemoveRedundantSpacesFormatter.java

src/main/java/org/jabref/logic/formatter/bibtexfields/ReplaceTabsBySpaceFormater.java

src/main/resources/l10n/JabRef_en.properties

koppor

LGTM 👍. The changes added require second review and thus this PR awaits a second review.

Siedlerchr · 2020-07-08T10:05:59Z

Thanks for your contribution! It would be nice if you could add some short documentation for the new formatters and the new fetcher to the help pages

koppor · 2020-07-08T10:29:17Z

Help page for formatters: https://github.com/JabRef/user-documentation/blob/master/en/finding-sorting-and-cleaning-entries/cleanupentries.md --> https://github.com/JabRef/user-documentation/blob/master/en/advanced/saveactions.md

Help page for fetchers: https://github.com/JabRef/user-documentation/tree/master/en/collect/import-using-online-bibliographic-database

daniel-price · 2020-07-08T21:26:03Z

Yep I'll add to the documentation!

Add Collection of Comp Sci Bibliographies fetcher

9a25b8e

Siedlerchr reviewed Jul 1, 2020

View reviewed changes

...java/org/jabref/logic/importer/fetcher/CollectionOfComputerScienceBibliographiesFetcher.java Outdated Show resolved Hide resolved

daniel-price added 3 commits July 1, 2020 16:08

Fix import

70ac2e9

Fix import and checkstyle

05a8000

Fix test bib files

a8e3738

koppor requested changes Jul 1, 2020

View reviewed changes

daniel-price and others added 7 commits July 1, 2020 20:51

Update CHANGELOG.md

66273f3

Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>

Change to retrieve BibTex results

2b7e223

Merge branch 'new-fetcher-collection-of-computer-science-bibliographi…

9a7bcd9

…es' of https://github.com/daniel-price/jabref into new-fetcher-collection-of-computer-science-bibliographies

Merge branch 'master' into new-fetcher-collection-of-computer-science…

6782bd9

…-bibliographies

Fix to dependency on Global

bd26ed1

Merge branch 'new-fetcher-collection-of-computer-science-bibliographi…

584bcac

…es' of https://github.com/daniel-price/jabref into new-fetcher-collection-of-computer-science-bibliographies

Merge branch 'master' into new-fetcher-collection-of-computer-science…

a7ac84e

…-bibliographies

koppor reviewed Jul 7, 2020

View reviewed changes

.../org/jabref/logic/importer/fetcher/CollectionOfComputerScienceBibliographiesFetcherTest.java Outdated Show resolved Hide resolved

daniel-price added 3 commits July 7, 2020 15:52

Make fetcher test more specific by checking each field explicitly

7bb2685

Merge branch 'new-fetcher-collection-of-computer-science-bibliographi…

3e798a6

…es' of https://github.com/daniel-price/jabref into new-fetcher-collection-of-computer-science-bibliographies

Fix to imports

43b94d9

koppor requested changes Jul 7, 2020

View reviewed changes

Update src/test/java/org/jabref/logic/importer/fetcher/CollectionOfCo…

2b2646b

…mputerScienceBibliographiesParserTest.java Co-authored-by: Oliver Kopp <kopp.dev@gmail.com>

koppor reviewed Jul 7, 2020

View reviewed changes

...ef/logic/importer/fetcher/collection_of_computer_science_bibliographies_multiple_results.xml Show resolved Hide resolved

daniel-price added 2 commits July 7, 2020 18:58

Add three formatters to fix new lines in abstract and digits in editors

b9ea9b0

Merge branch 'new-fetcher-collection-of-computer-science-bibliographi…

e28254a

…es' of https://github.com/daniel-price/jabref into new-fetcher-collection-of-computer-science-bibliographies

koppor requested changes Jul 7, 2020

View reviewed changes

Add localisation strings and renamed formatter

8375029

koppor reviewed Jul 7, 2020

View reviewed changes

src/main/java/org/jabref/logic/formatter/bibtexfields/ReplaceTabsBySpaceFormater.java Show resolved Hide resolved

koppor reviewed Jul 7, 2020

View reviewed changes

src/main/java/org/jabref/logic/formatter/bibtexfields/ReplaceTabsBySpaceFormater.java Show resolved Hide resolved

koppor reviewed Jul 7, 2020

View reviewed changes

src/main/resources/l10n/JabRef_en.properties Show resolved Hide resolved

koppor approved these changes Jul 7, 2020

View reviewed changes

Siedlerchr approved these changes Jul 8, 2020

View reviewed changes

Siedlerchr merged commit 558c810 into JabRef:master Jul 8, 2020

koppor mentioned this pull request Jun 13, 2022

Include "The Collection of Computer Science Bibliographies" as search engine JabRef/jabref-koppor#76

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Collection of Comp Sci Bibliographies fetcher #6664

Add Collection of Comp Sci Bibliographies fetcher #6664

daniel-price commented Jul 1, 2020 •

edited

Loading

koppor left a comment

koppor left a comment

koppor left a comment

koppor left a comment

Siedlerchr commented Jul 8, 2020

koppor commented Jul 8, 2020

daniel-price commented Jul 8, 2020

Add Collection of Comp Sci Bibliographies fetcher #6664

Add Collection of Comp Sci Bibliographies fetcher #6664

Conversation

daniel-price commented Jul 1, 2020 • edited Loading

koppor left a comment

Choose a reason for hiding this comment

koppor left a comment

Choose a reason for hiding this comment

koppor left a comment

Choose a reason for hiding this comment

koppor left a comment

Choose a reason for hiding this comment

Siedlerchr commented Jul 8, 2020

koppor commented Jul 8, 2020

daniel-price commented Jul 8, 2020

daniel-price commented Jul 1, 2020 •

edited

Loading