-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
ISBNtoBibTeX error mesage is now more clear #689
Conversation
Your commit 33bd952 changes each line in the file. Did you use Eclipse eGit? This causes issues at Windows because of the line endings or to change to Please read CONTRIBUTING.md which explains some details on the PRs. Especially that one should not use the Finally, for small changes such as merging the master branch or the correct usage of the localization, please do
In git gui, review and commit your changes. Then do a force push to overwrite your changes here. This squashes all commits into a single one. If you want to keep multiple commits, please continue reading at using-git-rebase. The first two steps are basically https://help.github.com/articles/syncing-a-fork/, where step 4 is skipped. Hint: At Windows: set the environment variable You can also send me a private mail if you have any issues in using git. |
And can you please merge your 4 commits into 1 commit as well as add a changelog entry describing your change? What is more:
|
Thanks for all the tips. I will look at this today in the evening. |
@Siedlerchr I think this would be helpful to be merged in for the next release. Could you perhaps complete the PR in the next days? |
@simonharrer I've been busy, but I will try to finish the PR tomorrow. |
Duplicate of #761 |
This is my first Pull Request.
Refs #684.