Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Better input box #26

Merged
merged 1 commit into from
Sep 25, 2022
Merged

Better input box #26

merged 1 commit into from
Sep 25, 2022

Conversation

ZiYueCommentary
Copy link
Collaborator

Added home key, end key, and delete key.

Insert key to switch insert mode.

Hold left/right arrow to fast move cursor.

Control + C to copy content of input box.

@Jabka666 Jabka666 merged commit 11f7ced into Jabka666:no_opt Sep 25, 2022
@Jabka666
Copy link
Owner

What is SelectedLength? Also I created dev branch, so make PRs to this branch

@ZiYueCommentary
Copy link
Collaborator Author

Original I want make a shift + arrow to select some text, but I give up at last. maybe I forgot delete that.

@Jabka666
Copy link
Owner

image
Because of SelectedLength = 0

@Jabka666
Copy link
Owner

SelectedLength is always 0

@Jabka666
Copy link
Owner

image
Also I got this error when pressed DELETE

@ZiYueCommentary
Copy link
Collaborator Author

image Because of SelectedLength = 0

I met this error when i developing too, the problem is selected text may at left of cursor, and maybe at right. this feature is more complex than others.

@Jabka666
Copy link
Owner

image
I think you forgot to use Max function to prevent negative value

@ZiYueCommentary
Copy link
Collaborator Author

🤔 I think you're right, and i found insert mode wont response for backspace.

@Jabka666
Copy link
Owner

Well, I'm requesting fixes for that

@ZiYueCommentary ZiYueCommentary mentioned this pull request Sep 25, 2022
Jabka666 added a commit that referenced this pull request Sep 25, 2022
This reverts commit 11f7ced, reversing
changes made to 25bcb05.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants