Plugins #42
Merged
Plugins #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The idea: * Move public interfaces to pkg/logsuck. There shouldn't be much code here, just structs and interfaces. Packages in this folder must not use internal packages. Packages in this folder are used by plugins. * Put plugins in the plugins directory. Plugins should not use any internal packages. Plugins implement interfaces and provide them into the dependency injection context on startup. * Internal packages can reference pkg/logsuck freely. Internal packages should not reference plugins. The only exceptions are the DependencyInjection.go file and tests which may use plugins for convenience. Plugins are currently not loadable dynamically. Instead, if you want to use a plugin you must update the DependencyInjection.go file and build. This seems like an acceptable tradeoff for now since there are some caveats with using the Go plugin system.
Having Gin log in its default format was causing issues when trying to parse Logsuck's own logs
This allows plugins and tasks to provide schemas for their configuration , making it much easier to configure them through the GUI. A downside of this is that SQLite configuration is moved to the "plugins" key in the config. Since SQLite is supposed to be a part of the base Logsuck build this is a bit ugly. Maybe SQLite should be special cased to also be included in the base configuration.
Avoids stuttering like "pipeline.PipelinePipe" and settles on prefixing implementations of interfaces (i.e. SqliteConfigRepository instead of ConfigRepositorySqlite)
Core plugins are treated specially when it comes to the config schema. Instead of being stored under the plugins key in the schema, core plugins can put their configuration in the root of the config object. This keeps compatibility with Logsuck configs created before plugins were added and looks much cleaner in the schema.
This lays the groundwork for making it possible to read events from other sources through plugins.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.