BACKLOG-21345: Add data attribute for tree item depth #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffffffelix
reviewed
Dec 20, 2023
There was a problem hiding this comment.
I propose to use the attribute aria-level to add the depth information on the element (MDN documentation)
What do you think?
gflores-jahia
force-pushed
the
BACKLOG-21345
branch
from
478effa to
5e44154
Compare
ffffffelix
approved these changes
May 14, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA
https://jira.jahia.org/browse/BACKLOG-21345
Description
Ran into an issue trying to select tree item for a given tree depth using style attribute.
Add a dedicated data attribute for specifying tree item depth to simplify css attribute selection.
Related PR context: Jahia/jcontent#1129 (comment)