Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

MOON-485: Fix default size icon on MenuItem #494

Merged
merged 1 commit into from
Jan 30, 2025
Merged

MOON-485: Fix default size icon on MenuItem #494

merged 1 commit into from
Jan 30, 2025
+9 −9

Conversation

ffffffelix
Copy link
Collaborator

JIRA

https://jira.jahia.org/browse/MOON-485

Description

  • Do not set the default value to null as it overrides the size of the icon
  • Set the default size icon on ListItem to default

@ffffffelix ffffffelix added the patch Increment the patch version when merged label Jan 30, 2025
@ffffffelix ffffffelix requested review from Eevolee and a team January 30, 2025 11:14
@ffffffelix ffffffelix merged commit 0450f15 into develop Jan 30, 2025
3 checks passed
@ffffffelix ffffffelix deleted the MOON-485 branch January 30, 2025 16:04
@gflores-jahia gflores-jahia mentioned this pull request Feb 3, 2025
Closed
@ffffffelix ffffffelix linked an issue Feb 4, 2025 that may be closed by this pull request
MOON-485 - Missing icon on Menu #698
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@gflores-jahia gflores-jahia gflores-jahia approved these changes

@Eevolee Eevolee Awaiting requested review from Eevolee

Assignees
No one assigned
Labels
patch Increment the patch version when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MOON-485 - Missing icon on Menu
2 participants
@ffffffelix @gflores-jahia