Skip to content

Commit

Permalink
manage: Removed friendly-errors-webpack-plugin (not compatible with W…
Browse files Browse the repository at this point in the history
…ebpack 5, not maintained), geowarin/friendly-errors-webpack-plugin#123

Signed-off-by: Jaid <jaid.jsx@gmail.com>
  • Loading branch information
Jaid committed May 27, 2021
1 parent bac605d commit 218f56a
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 213 deletions.
206 changes: 1 addition & 205 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
"fast-xml-parser": "^3.19.0",
"file-loader": "^6.2.0",
"flatted": "^3.1.1",
"friendly-errors-webpack-plugin": "^1.7.0",
"handlebars": "^4.7.7",
"handlebars-loader": "^1.7.1",
"has-content": "^1.1.1",
Expand Down
6 changes: 0 additions & 6 deletions src/generateWebpackConfig.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import CopyWebpackPlugin from "copy-webpack-plugin"
import ensureArray from "ensure-array"
import ensureStart from "ensure-start"
import flatted from "flatted"
import FriendlyErrorsWebpackPlugin from "friendly-errors-webpack-plugin"
import fs from "fs"
import hasContent from "has-content"
import JsdocTsdWebpackPlugin from "jsdoc-tsd-webpack-plugin"
Expand Down Expand Up @@ -131,7 +130,6 @@ export default (options = {}) => {
locale: "en-US",
sitemap: false,
googleAnalyticsOnlyInProduction: true,
friendlyErrors: false,
offline: false,
pwa: false,
browserSync: process.env.browserSync,
Expand Down Expand Up @@ -286,10 +284,6 @@ export default (options = {}) => {
},
}

if (options.friendlyErrors && env !== "test") {
config.plugins.push(new FriendlyErrorsWebpackPlugin)
}

if (options.clean) {
if (isObject(options.clean)) {
config.plugins.push(new CleanWebpackPlugin(options.clean))
Expand Down
1 change: 0 additions & 1 deletion src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ import generateWebpackConfig from "./generateWebpackConfig"
* @prop {boolean|object} [sitemap=false] For type `webapp`: If `true`, `sitemap-xml-webpack-plugin` will be used to output a `sitemap.xml`. If typeof `object`, this will be used as configuration for SitemapXmlWebpackPlugin constructor.
* @prop {string} [googleAnalyticsTrackingId] For type `webapp`: If typeof `string`, will be used as the Google Analytics tracking id and resolves any occurence of `GOOGLE_ANALYTICS_TRACKING_ID` to given id
* @prop {boolean} [googleAnalyticsOnlyInProduction=true] For type `webapp`: If `true`, option `googleAnalyticsTrackingId` will be ignored in any environment but `production`
* @prop {boolean} [friendlyErrors=false] If `true`, includes `friendly-errors-webpack-plugin`
* @prop {Object} [cepOptions={}] For type `adobeCep`: Additional option values that will be forwarded to `cep-webpack-plugin` constructor
* @prop {Object|boolean} [banner = true] If `true`, includes `pkg-banner-webpack-plugin`. If Object, this will be used as plugin options.
* @prop {Object|boolean} [offline = false] For type `webapp`: If `true`, includes `offline-plugin`. If Object, this will be used as plugin options.
Expand Down

0 comments on commit 218f56a

Please # to comment.