Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix: Response.error().ok === false #1412

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

jrmann100
Copy link
Contributor

Summary

  • Fixes error caused in 0c1d2b9, by which Response.error().ok === true where it should be false because Response.error().status < 200.
  • Adds test assertion

Explanation

Response.error internally constructs a valid Response and overwrites properties as necessary.

Now that Response must be constructed with a valid status, the constructed Response will be ok, so this property needs to be overwritten as well.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants