Fix MaxDepth problems introduced between 12.0.3 and 13.0.1 #2504
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2501 - have verified that the example provided in F# fails with no change and is resolved with the change.
Between 12.0.3 and 13.0.1 looks like
_maxDepth = 64;
was set in theJsonReader
constructor - any inheritors which use this default constructor end up with a max depth of 64 as a result - from the existing tests on max depth, it seems that this setting is not actually required in order to ensure the max depth is respected.I've also updated a few doc comments which erroneously claim the max depth as 128.
Update: as much as the initial fix (#2462) prevents a DOS attack, it does create other problems, such as 2501 - max depth is a bit tricky throughout the library, one option would be to make it mandatory on the
JsonReader
perhaps.