Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix import of assignments without due dates (#251) #384

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Conversation

JamesNZL
Copy link
Owner

@JamesNZL JamesNZL commented Jul 4, 2024

Fixes #251, where assignments without due dates were incorrectly ignored on import.

@JamesNZL JamesNZL added the bug Something isn't working label Jul 4, 2024
@JamesNZL JamesNZL self-assigned this Jul 4, 2024
@JamesNZL JamesNZL merged commit 0e59c2a into main Jul 4, 2024
1 check failed
@JamesNZL JamesNZL deleted the #251-no-due branch July 4, 2024 03:23
JamesNZL added a commit that referenced this pull request Jul 4, 2024
* fix(canvas): 🐛 do not store absence of due date as unix epoch (#251)

* fix(import): 🐛 correctly import assignments without due dates to notion (#251)
JamesNZL added a commit that referenced this pull request Jul 4, 2024
… (#387)

* Fix import of assignments without due dates (#251) (#384)

* fix(canvas): 🐛 do not store absence of due date as unix epoch (#251)

* fix(import): 🐛 correctly import assignments without due dates to notion (#251)

* refactor(types): 🏷️ refactor type declaration files

change to regular typescript files

* fix(validator): 🐛 fix timezone validation (#252)

* build(notion): 👽 pin notion api version

* feat(notion): ✨ parse notion page properties

* feat(options): ✨ add `notion.importChanges` options

* fix(interface): 💄 properly hide segmented controls

* refactor(types): 🧑‍💻 strongly type `Storage` key methods

* docs(readme): 📝 update `readme`

* docs(readme): 📝 update advanced options heading size

* feat(import)!: ✨ update existing pages if assignment has changed (#385)

BREAKING CHANGE: This requires a new previously unheld capability on the integration. Existing users must reauthorise with Notion.

* build(actions): 💚 fix gulp build
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assignment without due dates are not being imported into Notion
1 participant