Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ugprade to 3.1.6 #109

Merged
merged 19 commits into from
Jul 3, 2024
Merged

Ugprade to 3.1.6 #109

merged 19 commits into from
Jul 3, 2024

Conversation

JamieMair
Copy link
Owner

No description provided.

@JamieMair JamieMair added the enhancement New feature or request label Jun 22, 2024
@JamieMair JamieMair added this to the Port to v3 milestone Jun 22, 2024
@JamieMair JamieMair self-assigned this Jun 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0.78125% with 508 lines in your changes missing coverage. Please review.

Project coverage is 25.98%. Comparing base (0cab161) to head (d4f6f60).

Files Patch % Lines
src/LibMuJoCo/functions.jl 0.00% 323 Missing ⚠️
src/visualiser_wrappers.jl 0.00% 99 Missing ⚠️
src/function_constraints.jl 0.00% 50 Missing ⚠️
src/LibMuJoCo/structs.jl 0.00% 29 Missing ⚠️
src/named_access.jl 42.85% 4 Missing ⚠️
src/MuJoCo.jl 0.00% 2 Missing ⚠️
ext/VisualiserExt/defaulthandlers.jl 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   27.47%   25.98%   -1.49%     
==========================================
  Files          22       22              
  Lines        8568    10097    +1529     
==========================================
+ Hits         2354     2624     +270     
- Misses       6214     7473    +1259     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamieMair JamieMair requested a review from nic-barbara June 22, 2024 10:05
Copy link
Collaborator

@nic-barbara nic-barbara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great overall but some issues with finding file path for humanoid demo.

I really like the new API to show docs for Model and Data, that will be extremely useful and the Python bindings should look into doing the same :)

gen/named_access.jl Show resolved Hide resolved
src/io.jl Show resolved Hide resolved
@nic-barbara
Copy link
Collaborator

@JamieMair it all works fine on my Mac (except for loading the humanoid but that's just a file path issue). However, I have an Intel Mac, not one of the new M1/2/3 chips. The build error is: MuJoCo cannot be run under Rosetta 2 on an Apple Silicon machine.

I'm pretty sure MuJoCo works fine on modern Macs, but they might be doing something funky in the CMakeLists.txt Any ideas?

@JamieMair
Copy link
Owner Author

I've noticed that the builds on GitHub actions also fail for a previous PR? Perhaps there is an issue with the runners themselves?

@nic-barbara
Copy link
Collaborator

Possibly. I'll find someone with a more recent mac in my lab and get them to test a build.

@nic-barbara
Copy link
Collaborator

Can confirm that all tests pass on my colleague's mac, M1 (maybe M2) chip with Mac OS 14.5. Not sure what's failing in the CI tests.

@JamieMair
Copy link
Owner Author

Can confirm that all tests pass on my colleague's mac, M1 (maybe M2) chip with Mac OS 14.5. Not sure what's failing in the CI tests.

It turns out that Rosetta 2 is a translation layer to let ARM MacOS computers run x86 code, which is specifically disallowed in MuJoCo. The CI was set to "macos-latest" which is now macos-14 which is an arm based system, but the arch was set to x86_64, which causes Julia to load the MuJoCo_jll version that is built for x86_64, not the ARM version which is the problem. I have set the build to use macos-13 for x86_64 and macos-14 for ARM builds, but currently Julia actions breaks with aarch64, so I'm removed the CI for ARM for now.

@JamieMair JamieMair merged commit 4b16415 into main Jul 3, 2024
7 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants