-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Ugprade to 3.1.6 #109
Ugprade to 3.1.6 #109
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
- Coverage 27.47% 25.98% -1.49%
==========================================
Files 22 22
Lines 8568 10097 +1529
==========================================
+ Hits 2354 2624 +270
- Misses 6214 7473 +1259 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great overall but some issues with finding file path for humanoid demo.
I really like the new API to show docs for Model
and Data
, that will be extremely useful and the Python bindings should look into doing the same :)
@JamieMair it all works fine on my Mac (except for loading the I'm pretty sure MuJoCo works fine on modern Macs, but they might be doing something funky in the |
I've noticed that the builds on GitHub actions also fail for a previous PR? Perhaps there is an issue with the runners themselves? |
Possibly. I'll find someone with a more recent mac in my lab and get them to test a build. |
Can confirm that all tests pass on my colleague's mac, M1 (maybe M2) chip with Mac OS 14.5. Not sure what's failing in the CI tests. |
It turns out that Rosetta 2 is a translation layer to let ARM MacOS computers run x86 code, which is specifically disallowed in MuJoCo. The CI was set to "macos-latest" which is now macos-14 which is an arm based system, but the arch was set to x86_64, which causes Julia to load the MuJoCo_jll version that is built for x86_64, not the ARM version which is the problem. I have set the build to use macos-13 for x86_64 and macos-14 for ARM builds, but currently Julia actions breaks with aarch64, so I'm removed the CI for ARM for now. |
No description provided.