Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature/angle conversions #169

Merged
merged 11 commits into from
Apr 24, 2024
Merged

Feature/angle conversions #169

merged 11 commits into from
Apr 24, 2024

Conversation

Jammy2211
Copy link
Owner

Updates the autogalaxy.convert package with the following additional checks:

  • When ell_comps of a mass profile or light are converted to an angle, the angle must be between -45.0 and 135.0 degrees without a loop at the boundaries.

  • When gamma_1 and gamma_2 of a shear are converted to a shear angle, the angle must be between -45.0 and 135.0 degrees without a loop at the boundaries.

  • When multipole_comps are converted to phi_m, the multipole angle, it must be between values which again removing a boundary loop.

All checks ensure that when these values are computed to estimate their errors from a non-linear search, the estimation does not cycle around a boudnary and bias the inferred value.

This PR also adds docstrings.

Thank you @samlange04 for doing the hard work of figuring out the required conversions!

@Jammy2211 Jammy2211 merged commit 0246f93 into main Apr 24, 2024
9 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant