fix: correct theme memory display template for byte/gigabyte conversion #4557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsion Updated conversion factor from 1000000000 to 1073741824. This change ensures memory usage is correctly displayed as a gigabyte (2^30 bytes).
|
@all-contributors please add @ChrisNSki for design This is pure magic 🪄! @holopin-bot @ChrisNSki wizard |
|
Congratulations @ChrisNSki, you just earned a badge! Here it is: https://holopin.io/claim/clqcmprs013180fjmshz0v9av This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
|
I've put up a pull request to add @ChrisNSki! 🎉 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated conversion factor from 1000000000 to 1073741824. This change ensures memory usage is correctly displayed as a gigabyte (2^30 bytes).
Prerequisites
Description
This pull request fixes the byte-to-gigabyte conversion in 7 oh-my-posh theme templates. The original templates used 1,000,000,000 as the divisor. This update changes the divisor to the value of 1,073,741,824 (2^30 bytes), this should resolve an issues with accurate gigabyte representation in memory usage displays on those themes.