Attempt a solution for #22 #23
Conversation
Trying to fix #22. This ensures that checks happen right before addition, so there’s no way to have multiple notifications with the same content.
grunt build
|
The timeout is used to add the message in the next apply cycle of angular. You can also force an apply but this will result in errors (hence the docs recommend using timeout instead of apply). I like your fix because the logic of addMessage should check if the message is already added or not. I see that some stuff is added to the build files but I cannot find the matching code in the src directory? Can you add all your code changes to the src directory? Did it work? Any thoughts on if the timeout is really needed or not? |
|
Using There's two commits in the PR, one with the changes to source, and one with the updated built files. I split it up so if you didn't want updated built files, you can ignore the second commit. |
|
Also, I have a copy with these changes applied and I'm using it in my application. I haven't had any problems so far. |
No description provided.