Fix #2629 undoing group duplication creates broken objects

JannisX11 · Jan 7, 2025 · 787cdd6 · 787cdd6
1 parent 5cbccc9
commit 787cdd6
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/js/outliner/outliner.js b/js/outliner/outliner.js
@@ -1067,12 +1067,16 @@ SharedActions.add('duplicate', {
 		}
 
 		let all_new = [];
-		for (let group of Group.multi_selected) {
+		let old_selected_groups = Group.multi_selected.slice();
+		Group.multi_selected.empty();
+		for (let group of old_selected_groups) {
+			group.selected = false;
 			let new_group = group.duplicate();
 			new_group.forEachChild(g => all_new.push(g), Group, true);
+			new_group.multiSelect();
 		}
-		new_group.multiSelect();
 
+		updateSelection();
 		Undo.finishEdit('Duplicate group', {outliner: true, elements: elements.slice().slice(cubes_before), selection: true});
 
 		if (Animation.all.length) {