Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(jans-cli-tui): move agama archiever to jans-cli directory #5721

Merged
merged 4 commits into from
Aug 3, 2023
Merged

fix(jans-cli-tui): move agama archiever to jans-cli directory #5721

merged 4 commits into from
Aug 3, 2023

Conversation

devrimyatar
Copy link
Contributor

closes #5720

@devrimyatar devrimyatar added kind-bug Issue or PR is a bug in existing functionality comp-jans-cli-tui Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR labels Aug 2, 2023
@devrimyatar devrimyatar marked this pull request as draft August 2, 2023 08:33
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2023

[jans-cli] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 3, 2023

[jans-linux-setup] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@devrimyatar devrimyatar marked this pull request as ready for review August 3, 2023 08:30
@yuriyz yuriyz merged commit 61053f0 into main Aug 3, 2023
@yuriyz yuriyz deleted the jans-cli-tui-agama-archiever branch August 3, 2023 10:22
This was referenced Sep 17, 2023
Merged
Merged
devrimyatar added a commit that referenced this pull request Dec 30, 2023
@devrimyatar
fix(jans-cli-tui): move agama archiever to jans-cli directory (#5721)
7890f27 
* fix(jans-cli-tui): move agama archiever to jans-cli directory

* fix(jans-cli): code smells

* feat(jans-cli-tui): link /opt/jans/bin/gama-archieve-cli.py

* fix(jans-linux-setup): code smell

Signed-off-by: Mustafa Baser <mbaser@mail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@yuriyz yuriyz yuriyz approved these changes

@smansoft smansoft Awaiting requested review from smansoft

@yurem yurem Awaiting requested review from yurem yurem is a code owner

Assignees
No one assigned
Labels
comp-jans-cli-tui Component affected by issue or PR comp-jans-linux-setup Component affected by issue or PR kind-bug Issue or PR is a bug in existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(jans-cli): move agama archiever script to jans-cli
2 participants
@devrimyatar @yuriyz