Skip to content

feat(): unicode extended char support for column name or alias #58

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Nov 5, 2023

Conversation

luizzappa
Copy link
Contributor

Currently, you cannot name (or alias) a column with certain Latin characters without using quotes, even though this is supported by MySQL syntax. In this PR, I added this.

Parser error:
image

MySQL syntax:

Permitted characters in unquoted identifiers:
- ASCII: [0-9,a-z,A-Z$_] (basic Latin letters, digits 0-9, dollar, underscore)
- Extended: U+0080 .. U+FFFF

@luizzappa luizzappa force-pushed the unicode-extended branch 2 times, most recently from 31faa6a to c4b243e Compare October 22, 2023 18:20
@luizzappa
Copy link
Contributor Author

Sorry for the force, there was code that wasn't supposed to be committed

@albin3 albin3 added the bug label Oct 31, 2023
@albin3
Copy link
Member

albin3 commented Oct 31, 2023

hi, @luizzappa thanks for the pr, it is a serious problem. Could you update this pr like this:

  1. I think there is no need to modify lines in src/sqlParser.jison which logic is not modified. It will increase review or blame cost in the future.
  2. It seems [a-zA-Z0-9_\u0080-\uFFFF]* return 'IDENTIFIER' is a better pattern, will fix this issue these days.

@luizzappa
Copy link
Contributor Author

@albin3, Done. In my first commit I had indented the other lines to maintain the formatting, with this smaller pattern suggested by you I didn't need to do that, thanks.

https://github.com/JavaScriptor/js-sql-parser/compare/master..10646422beaee247db28c171ca791f2880253a19

Copy link
Member

@albin3 albin3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@albin3
Copy link
Member

albin3 commented Nov 5, 2023

hi @luizzappa , lGTM.

@albin3 albin3 merged commit ca3c259 into JavaScriptor:master Nov 5, 2023
@albin3
Copy link
Member

albin3 commented Apr 3, 2024

released at js-sql-parser@1.6.0

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants