Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Convert LESS to SCSS and re-organise #544

Merged
merged 1 commit into from
Oct 29, 2015
Merged

Convert LESS to SCSS and re-organise #544

merged 1 commit into from
Oct 29, 2015

Conversation

bassjacob
Copy link
Collaborator

Convert LESS to SCSS using the less2sass gem. Fix references to some
mixins in the individual scss files, and allow the importing of the
variables separately from the components so an end user can override the
variables before use.

Convert LESS to SCSS using the less2sass gem. Fix references to some
mixins in the individual scss files, and allow the importing of the
variables separately from the components so an end user can override the
variables before use.
@bassjacob
Copy link
Collaborator Author

Hi :)

I'm not sure how/if you'd like to handle compiling the scss -> css since it seems like the LESS files are still your active stylesheet. This is probably really specific to my use case, but I needed to use this in an existing SASS ecosystem.

Use case is that I can now import the variables and over-ride them in my own sass file before importing the component styles.

I'm currently testing this locally, but it seems to be a 1-1 conversion. Is this an addition you're happy with?

@JedWatson
Copy link
Owner

Thanks - I'm not sure how we'll approach maintaining both versions, but at the moment I'm glad to have this more friendly for SASS users!

JedWatson added a commit that referenced this pull request Oct 29, 2015
Convert LESS to SCSS and re-organise
@JedWatson JedWatson merged commit 066a8de into JedWatson:master Oct 29, 2015
@JedWatson JedWatson mentioned this pull request Oct 29, 2015
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants