Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

🩹 (notion) Slug.Preview updated to account for UTC [b] #3114

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

JeromeFitz
Copy link
Owner

@JeromeFitz JeromeFitz commented Dec 30, 2024

Notion API (probably rightfully) changed to have root request be UTC instead of the User's Timezone who is making the request. Which is cool (but from what I can tell is not documented) so all the dynamic dates were wrong for events and as a result fully-qualified URLs (nice).

Update on the Notion side is to move Slug.Preview to Slug.Preview.UTC and in its stead ensure Slug.Preview is currently US Eastern based. 😑

Slug.Preview

join(["", "events", formatDate(dateSubtract(prop("Date"), 5, "hours"), "YYYY/MM/DD"), prop("Slug")], "/")

Slug.Preview.UTC

join(["", "events", formatDate(prop("Date"), "YYYY"), formatDate(prop("Date"), "MM"), formatDate(prop("Date"), "DD"), prop("Slug")], "/")

Also update shows for January 2025 as I have been slacking on my macking for some calendar updates. Been doing one-off shows here and there not always worth mentioning based on it mostly being experimental (even for me).

@BotJerome
Copy link
Collaborator

This pull request has been deployed to Vercel.

Latest commit: 504b503
✅ Preview: https://jeromefitzgerald-n2d0lc05w-j-e-r-o-m-e.vercel.app
🔍 Inspect: https://vercel.com/j-e-r-o-m-e/jeromefitzgerald/DoGpAL8jLeZPxFRWRcZ83x5MpNyP

View Workflow Logs

@JeromeFitz JeromeFitz added the 🥳️ LGTM Automerge: Let's Get This Merged label Dec 30, 2024
@kodiakhq kodiakhq bot merged commit 6792df7 into main Dec 30, 2024
3 checks passed
@kodiakhq kodiakhq bot deleted the config/upcoming-shows-2025-01 branch December 30, 2024 18:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
🥳️ LGTM Automerge: Let's Get This Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants