Skip to content

feat(instance): Add audio input device controls #40

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 18 commits into from
Apr 28, 2025
Merged

Conversation

BlindMaster24
Copy link
Collaborator

No description provided.

Copy link
Owner

@JessicaTegner JessicaTegner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally it looks okay. But a general note is, that whenever the super class (sdk.TeamTalk) has a function for x, we use that instead of the factory functions (the one starting with '-' that requires a tt pointer)

@BlindMaster24
Copy link
Collaborator Author

@JessicaTegner Done!

@BlindMaster24 BlindMaster24 deleted the 1.3.2 branch April 28, 2025 09:51
@JessicaTegner JessicaTegner restored the 1.3.2 branch April 28, 2025 10:03
@JessicaTegner JessicaTegner reopened this Apr 28, 2025
@BlindMaster24 BlindMaster24 dismissed JessicaTegner’s stale review April 28, 2025 15:21

Everything was discussed in PMs.

@BlindMaster24 BlindMaster24 merged commit 36d3a37 into master Apr 28, 2025
25 checks passed
@BlindMaster24 BlindMaster24 deleted the 1.3.2 branch April 28, 2025 16:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants