Fixed appearing of text editing menu in Selection Container in iOS #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mazunin-v-jb
requested review from
elijah-semyonov and
ASalavei
and removed request for
elijah-semyonov and
ASalavei
ASalavei
reviewed
Apr 18, 2024
|
|
||
| updateView() | ||
|
|
||
| textUIView?.let { |
There was a problem hiding this comment.
This lines looks identical to L276 . Could you please group them?
mazunin-v-jb
requested review from
MatkovIvan
and removed request for
elijah-semyonov
…d broking textfield changes, removed some printlns
…separate methods to reuse them
mazunin-v-jb
force-pushed
the
v.mazunin/context-menu-in-cupertino-selection-container
branch
from
ade8253
to
67166a9
Compare
MatkovIvan
reviewed
Apr 19, 2024
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/platform/UIKitTextInputService.uikit.kt
Outdated
Show resolved
Hide resolved
compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/platform/UIKitTextInputService.uikit.kt
Outdated
Show resolved
Hide resolved
MatkovIvan
approved these changes
Apr 19, 2024
MatkovIvan
deleted the
v.mazunin/context-menu-in-cupertino-selection-container
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Testing
Test: Open test app, go Components -> Selection, try to select text in selection container
Issues Fixed
Fixes:
SelectionContainercan't show options menu on iOS compose-multiplatform#4322Google CLA
You need to sign the Google Contributor’s License Agreement at https://cla.developers.google.com/.
This is needed since we synchronise most of the code with Google’s AOSP repository. Signing this agreement allows us to synchronise code from your Pull Requests as well.