Fix initial cursor position in empty TextField when TextAlignment is set explicitly #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mazunin-v-jb
changed the title
m-sasha
reviewed
May 13, 2024
| @@ -57,6 +58,8 @@ internal class SkiaParagraph( | |||
| internal val defaultFont | |||
| get() = layouter.defaultFont | |||
|
|
|||
| private val textAlign: TextAlign = layouter.textStyle.textAlign | |||
There was a problem hiding this comment.
No need to put it in a variable, just use it at the one place where it's needed.
It's both safer (no need to understand whether the value can change) and takes less memory.
compose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/SkiaParagraph.skiko.kt
Outdated
Show resolved
Hide resolved
|
You should add unit tests for this. |
MatkovIvan
reviewed
May 13, 2024
|
It seems we have one more issue duplicate - JetBrains/compose-multiplatform#2711 |
…Position` to make it more simple and intuitive
mazunin-v-jb
force-pushed
the
v.mazunin/fix-cursor-in-aligned-textfield
branch
from
a8aed8f to
f933000
Compare
MatkovIvan
reviewed
Jun 10, 2024
compose/ui/ui-text/src/skikoTest/kotlin/androidx/compose/ui/text/SkikoParagraphTest.kt
Outdated
Show resolved
Hide resolved
MatkovIvan
approved these changes
Jun 10, 2024
compose/ui/ui-text/src/skikoMain/kotlin/androidx/compose/ui/text/SkiaParagraph.skiko.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Ivan Matkov <ivan.matkov@jetbrains.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After focusing on the textfield and before entering any text, now blinking cursor will be positioned in accordance with TextAlignment.
Fixes https://youtrack.jetbrains.com/issue/COMPOSE-1360/
Fixes JetBrains/compose-multiplatform#2711
Fixes JetBrains/compose-multiplatform#3098
Fixes JetBrains/compose-multiplatform#4611
Testing
Manual testing.
Release Notes
Fixes - Multiple Platforms
TextFieldwith explicitly setTextAlignment.Google CLA
You need to sign the Google Contributor’s License Agreement at https://cla.developers.google.com/.
This is needed since we synchronise most of the code with Google’s AOSP repository. Signing this agreement allows us to synchronise code from your Pull Requests as well.