Refactor Text Edit menu context actions #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix crash when using UIMenuController for iOS 12.
ASalavei
changed the title
MatkovIvan
approved these changes
May 21, 2024
mazunin-v-jb
approved these changes
May 23, 2024
MatkovIvan
pushed a commit
that referenced
this pull request
May 29, 2024
Use UIEditMenuInteraction for iOS 16+ for context menus in text fields. Fix crash when using UIMenuController for iOS 12. ## Solution Move all Edit Menu code to Objc lib to: - hide `UIEditMenuInteraction` from KMM to prevent crash on launch - keep simple and convenient interface for Edit Menu
|
Is there no equivalent to |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use UIEditMenuInteraction for iOS 16+ for context menus in text fields.
Fix crash when using UIMenuController for iOS 12.
Solution
Move all Edit Menu code to Objc lib to:
UIEditMenuInteractionfrom KMM to prevent crash on launch