-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix web datepicker text field illegal input crash #1368
Fix web datepicker text field illegal input crash #1368
Conversation
...l3/material3/src/skikoMain/kotlin/androidx/compose/material3/KotlinxDatetimeCalendarModel.kt
Outdated
Show resolved
Hide resolved
Do you known why iOS CI runs here instead of web? |
it seems that iOS tests run for all changes, regardless of the where the change was added. |
Expensive macos runners aren't happy about that 😆 |
anyway, in this case skikoTest was changed and the library version was updated, so it would make sense for iOS tests to run. And ideally to pass... But, CI doesn't want to generate the test report :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tests passed locally on all platforms.
Thank you for this contribution :)
- Update kotlinx.datetime to [0.6.0](https://github.com/Kotlin/kotlinx-datetime/releases/tag/v0.6.0) - Migrate locale-invariant web formatting/parsing to kotlinx.datetime - Catch parsing exceptions <!-- Optional --> Fixes JetBrains/compose-multiplatform#4856 ## Testing `KotlinxDatetimeCalendarModelTest.illegalDateParsingDoesNotThrowException` <!-- Optional --> This should be tested by QA ## Release Notes ### Fixes - Web - Fixed crash when date picker text field receives illegal input
Fixes JetBrains/compose-multiplatform#4856
Testing
KotlinxDatetimeCalendarModelTest.illegalDateParsingDoesNotThrowException
This should be tested by QA
Release Notes
Fixes - Web