Fixed keyboard appearing in SelectionContainer in iOS #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatkovIvan
reviewed
Jul 15, 2024
There was a problem hiding this comment.
I guess it will also fix JetBrains/compose-multiplatform#5088
|
you right, I forgot to add that |
ASalavei
approved these changes
Jul 17, 2024
|
It would be great to add some uikit instrumented tests for this. However, its current implementation does not support imitation of double / triple taps (which is crucial for testing this), so it is decided to merge it without auto tests. |
mazunin-v-jb
deleted the
v.mazunin/fix-keybord-appearing-in-selection-container
branch
|
I will test alpha02 in a bit and let you know if it fixes #5088 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the keyboard appearing in SelectionContainer in iOS
Fixes: JetBrains/compose-multiplatform#4986
https://youtrack.jetbrains.com/issue/CMP-1554/iOS-Selection-Container-shows-keyboard-while-selecting-text
JetBrains/compose-multiplatform#5088
Testing
Manual. Open Test App, go Components -> Selection, double tap any selectable text, on-screen keyboard shouldn't appear.
Release Notes
Fixes - iOS
Google CLA
You need to sign the Google Contributor’s License Agreement at https://cla.developers.google.com/.
This is needed since we synchronise most of the code with Google’s AOSP repository. Signing this agreement allows us to synchronise code from your Pull Requests as well.