Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Deprecate defaultUIKitMain() in order to remove it #1585

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Deprecate defaultUIKitMain() in order to remove it #1585

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
987c09e
Fix Swipe Back crash when app is launched from defaultUIKitMain
ASalavei Sep 23, 2024
717fbe4
Update deprecation message
ASalavei Sep 27, 2024
ee9c2c2
Revert changes
ASalavei Sep 27, 2024
706702b
Update deprecation message
ASalavei Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 23 additions & 3 deletions compose/ui/ui/src/uikitMain/kotlin/androidx/compose/ui/main/DefaultIOSMain.uikit.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,28 @@

package androidx.compose.ui.main

import kotlinx.cinterop.*
import platform.UIKit.*
import platform.Foundation.*
import kotlinx.cinterop.ObjCObjectBase
import kotlinx.cinterop.autoreleasepool
import kotlinx.cinterop.cstr
import kotlinx.cinterop.memScoped
import kotlinx.cinterop.toCValues
import platform.Foundation.NSStringFromClass
import platform.UIKit.UIApplication
import platform.UIKit.UIApplicationDelegateProtocol
import platform.UIKit.UIApplicationDelegateProtocolMeta
import platform.UIKit.UIApplicationMain
import platform.UIKit.UIResponder
import platform.UIKit.UIResponderMeta
import platform.UIKit.UIScreen
import platform.UIKit.UIViewController
import platform.UIKit.UIWindow

private var _rootViewController: UIViewController? = null

@Deprecated(
"Crashes app under some circumstances. Will be removed in the upcoming release.",
ReplaceWith("Create UIApplication on your own if needed.")
)
fun defaultUIKitMain(executableName: String, rootViewController: UIViewController) {
_rootViewController = rootViewController
val args = emptyArray<String>()
Expand All @@ -34,6 +50,10 @@ fun defaultUIKitMain(executableName: String, rootViewController: UIViewControlle
}
}

@Deprecated(
"Will be removed in the upcoming release.",
ReplaceWith("Implement UIApplicationDelegate on your own if needed.")
)
class DefaultIOSAppDelegate : UIResponder, UIApplicationDelegateProtocol {
companion object Companion : UIResponderMeta(), UIApplicationDelegateProtocolMeta

Expand Down